[DSLX Fuzz Testing] Rewrite how FuzzTestConverter deals with constants;#4197
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
[DSLX Fuzz Testing] Rewrite how FuzzTestConverter deals with constants;#4197copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_910153472
branch
2 times, most recently
from
b8bc76b to
5db068a
Compare
instead of looking up their Constant AST node, it properly looks up the `InterpValue` for the AST in the type info. For constant ranges, arrays or tuples, it processes each type of `InterpValue` in a new method that used a similar pattern to its AST version. To distinguish constant arrays from constant ranges (both of which have the `IsArray` bit set), it uses the new `is_range` flag on `InterpValue`. Finally, fixed a bug with ranges; DSLX ranges are exclusive but Google Fuzztest domains are inclusive, so we have to decrement the "max" field as appropriate. PiperOrigin-RevId: 910153472
copybara-service
Bot
force-pushed
the
test_910153472
branch
from
5db068a to
8c034da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DSLX Fuzz Testing] Rewrite how FuzzTestConverter deals with constants;
instead of looking up their Constant AST node, it properly looks up the
InterpValuefor the AST in the type info.For constant ranges, arrays or tuples, it processes each type of
InterpValuein a new method that used a similar pattern to its AST version.To distinguish constant arrays from constant ranges (both of which have
the
IsArraybit set), it uses the newis_rangeflag onInterpValue.Finally, fixed a bug with ranges; DSLX ranges are exclusive but
Google Fuzztest domains are inclusive, so we have to decrement the "max"
field as appropriate.