Add ScopedRecordLogs for capturing and recording test logs.#4212
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Add ScopedRecordLogs for capturing and recording test logs.#4212copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_911553182
branch
from
04e6a28 to
c3fc0d3
Compare
This change introduces `LogCollectorSink`, an `absl::LogSink` implementation that collects log messages. It also adds `ScopedRecordLogs`, a test utility that uses `LogCollectorSink` to capture all logs within its scope and records them as a test property using `testing::Test::RecordProperty` upon destruction. This is useful for debugging test failures by having the relevant logs attached to the test results. PiperOrigin-RevId: 911553182
copybara-service
Bot
force-pushed
the
test_911553182
branch
from
c3fc0d3 to
cb74e6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ScopedRecordLogs for capturing and recording test logs.
This change introduces
LogCollectorSink, anabsl::LogSinkimplementation that collects log messages. It also addsScopedRecordLogs, a test utility that usesLogCollectorSinkto capture all logs within its scope and records them as a test property usingtesting::Test::RecordPropertyupon destruction. This is useful for debugging test failures by having the relevant logs attached to the test results.