Resolve indirect type annotations for generics before writing to table.#4217
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Resolve indirect type annotations for generics before writing to table.#4217copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
Previously, `CleanseGenericTypeArgument` would return a TVTA pointing to another generic in these cases and write that annotation to the table. Change it to first attempt to resolve the indirect annotation. PiperOrigin-RevId: 912098435
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve indirect type annotations for generics before writing to table.
Previously,
CleanseGenericTypeArgumentwould return a TVTA pointing toanother generic in these cases and write that annotation to the table.
Change it to first attempt to resolve the indirect annotation.