Repository navigation
fix: include mismatched PHP namespaces in package error - #853
amarkdotdev wants to merge 4 commits into
Conversation
|
integration test failure looks like infra — bazel can't fetch zlib (checksum mismatch from zlib.net), not related to this change |
Surface the package name, distinct namespaces, and per-file namespace mapping so casing typos are easier to locate in large proto packages. Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com> Signed-off-by: Aaron <amark@g.jct.ac.il>
a24b325 to
924d9f9
Compare
|
rebased onto main |
|
Friendly ping for merge when someone from the approver group has a moment. Presubmit was green last I checked. |
|
@amarkdotdev looks like we have some test failures |
Signed-off-by: Aaron <amark@g.jct.ac.il>
|
@bshaffer good catch. CI was failing because |
|
@bshaffer Merge ping when convenient. PHPUnit fix for protobuf 5.x is on the branch; multi-approvers/presubmit look like infra gates on my last run. |
…ismatch-error Signed-off-by: Aaron <amark@g.jct.ac.il>
|
Synced with main again; watching CI. |
|
Hi, I see some CI red (multi-approvers, gapic-generator-php-presubmit (gapic-images)). I am happy to dig in or push a fix; shout if there is something upstream side blocking fork runs. |
Summary
Fixes #668
Notes
Test plan
CodeGeneratortests/Unit/CodeGeneratorNamespaceTest.php(or full unit suite) in CI