Skip to content

chore: Remove Code Coverage requirements#1871

Merged
lqiu96 merged 2 commits intomainfrom
remove-code-cov-req
Mar 19, 2026
Merged

chore: Remove Code Coverage requirements#1871
lqiu96 merged 2 commits intomainfrom
remove-code-cov-req

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Jan 6, 2026

91% code coverage is quite high. We'll rely on maintainers and developers for best effort of coverage on implementations instead of an arbitrary metric.

This also removes issues from local development:

[WARNING] Rule violated for bundle google-auth-library-oauth2-http: lines covered ratio is 0.881, but expected minimum is 0.910
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Google Auth Library for Java 1.43.1-SNAPSHOT:
[INFO]
[INFO] Google Auth Library for Java ....................... SUCCESS [  1.582 s]
[INFO] Google Auth Library for Java - Credentials ......... SUCCESS [  1.814 s]
[INFO] Google Auth Library for Java - OAuth2 HTTP ......... FAILURE [01:05 min]
[INFO] Google Auth Library for Java - Google App Engine ... SKIPPED
[INFO] Google Auth Library for Java BOM ................... SUCCESS [  0.082 s]
[INFO] Google Auth Library for Java - Cab Token Generator . SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:09 min (Wall Clock)
[INFO] Finished at: 2026-03-19T17:12:36-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.12:check (jacoco-check) on project google-auth-library-oauth2-http: Coverage checks have not been met. See log for details. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :google-auth-library-oauth2-http

@lqiu96 lqiu96 requested review from a team and zhumin8 January 6, 2026 15:55
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 6, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

@lqiu96 lqiu96 merged commit c3d80ef into main Mar 19, 2026
27 checks passed
@lqiu96 lqiu96 deleted the remove-code-cov-req branch March 19, 2026 21:57
lqiu96 added a commit that referenced this pull request Mar 20, 2026
* chore: Remove Code Coverage requirements

* chore: Remove redelcaration in child pom
lqiu96 added a commit that referenced this pull request Mar 20, 2026
* fix(oauth2): mask sensitive tokens in HTTP logs

Disables automatic logging by google-http-java-client in StsRequestHandler and UrlIdentityPoolSubjectTokenSupplier to prevent leakage of access_token and subject_token. Explicit secure logging via LoggingUtils is introduced instead, which hashes sensitive keys.

* chore: Remove Code Coverage requirements (#1871)

* chore: Remove Code Coverage requirements

* chore: Remove redelcaration in child pom

* chore: Disable request logging for all credential types

* chore: Restore removed logs

* chore: Fix lint issues

* chore: Add comments and accessToken sensitive token

* chore: Fix lint issues

* test: add Token masking tests for SA and Impersonated Credentials

* chore: Add tests for masking sensitive tokens

* chore: Remove secure logging messaging

* chore: remove sensitive key mask redundant logic

* chore: Add javadocs for the LoggingUtil methods

* chore: Remove last reference to secure logging

* fix: resolve NPE and ClassCastException preventing proper payload logging

* chore: Fix failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants