chore: improve typing in api_core.exceptions#16115
chore: improve typing in api_core.exceptions#16115daniel-sanche wants to merge 2 commits intomainfrom
Conversation
GoogleApiCallError.grpc_status_code had no typing, so mypy will assume the value is always None
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the type annotations within the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates type annotations in google.api_core.exceptions.GoogleAPICallError. It replaces Union[int, None] with Optional[int] and adds a type hint for grpc_status_code. The suggestion to use a forward reference for grpc.StatusCode and guard the grpc import with TYPE_CHECKING is retained as it correctly addresses how to maintain grpc as an optional dependency for type hinting purposes, aligning with best practices for optional dependencies.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
GoogleApiCallError.grpc_status_code had no typing, so mypy will assume the value is always None
This PR adds the proper type annotation