Skip to content

fix(dataplex)!: remove deprecated Explore-related methods and messages from public client libraries #33820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aandreassa wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(dataplex)!: remove deprecated Explore-related methods and messages from public client libraries #33820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 36 additions & 26 deletions google-cloud-dataplex-v1/.owlbot-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,20 @@
"lib/google/cloud/dataplex/v1/cmek_service/rest/service_stub.rb",
"lib/google/cloud/dataplex/v1/cmek_services_pb.rb",
"lib/google/cloud/dataplex/v1/content_pb.rb",
"lib/google/cloud/dataplex/v1/content_service.rb",
"lib/google/cloud/dataplex/v1/content_service/client.rb",
"lib/google/cloud/dataplex/v1/content_service/credentials.rb",
"lib/google/cloud/dataplex/v1/content_service/paths.rb",
"lib/google/cloud/dataplex/v1/content_service/rest.rb",
"lib/google/cloud/dataplex/v1/content_service/rest/client.rb",
"lib/google/cloud/dataplex/v1/content_service/rest/service_stub.rb",
"lib/google/cloud/dataplex/v1/content_services_pb.rb",
"lib/google/cloud/dataplex/v1/data_discovery_pb.rb",
"lib/google/cloud/dataplex/v1/data_documentation_pb.rb",
"lib/google/cloud/dataplex/v1/data_product_service.rb",
"lib/google/cloud/dataplex/v1/data_product_service/client.rb",
"lib/google/cloud/dataplex/v1/data_product_service/credentials.rb",
"lib/google/cloud/dataplex/v1/data_product_service/operations.rb",
"lib/google/cloud/dataplex/v1/data_product_service/paths.rb",
"lib/google/cloud/dataplex/v1/data_product_service/rest.rb",
"lib/google/cloud/dataplex/v1/data_product_service/rest/client.rb",
"lib/google/cloud/dataplex/v1/data_product_service/rest/operations.rb",
"lib/google/cloud/dataplex/v1/data_product_service/rest/service_stub.rb",
"lib/google/cloud/dataplex/v1/data_products_pb.rb",
"lib/google/cloud/dataplex/v1/data_products_services_pb.rb",
"lib/google/cloud/dataplex/v1/data_profile_pb.rb",
"lib/google/cloud/dataplex/v1/data_quality_pb.rb",
"lib/google/cloud/dataplex/v1/data_scan_service.rb",
Expand Down Expand Up @@ -123,9 +127,9 @@
"proto_docs/google/cloud/dataplex/v1/business_glossary.rb",
"proto_docs/google/cloud/dataplex/v1/catalog.rb",
"proto_docs/google/cloud/dataplex/v1/cmek.rb",
"proto_docs/google/cloud/dataplex/v1/content.rb",
"proto_docs/google/cloud/dataplex/v1/data_discovery.rb",
"proto_docs/google/cloud/dataplex/v1/data_documentation.rb",
"proto_docs/google/cloud/dataplex/v1/data_products.rb",
"proto_docs/google/cloud/dataplex/v1/data_profile.rb",
"proto_docs/google/cloud/dataplex/v1/data_quality.rb",
"proto_docs/google/cloud/dataplex/v1/data_taxonomy.rb",
Expand Down Expand Up @@ -169,42 +173,52 @@
"snippets/catalog_service/create_entry_group.rb",
"snippets/catalog_service/create_entry_link.rb",
"snippets/catalog_service/create_entry_type.rb",
"snippets/catalog_service/create_metadata_feed.rb",
"snippets/catalog_service/create_metadata_job.rb",
"snippets/catalog_service/delete_aspect_type.rb",
"snippets/catalog_service/delete_entry.rb",
"snippets/catalog_service/delete_entry_group.rb",
"snippets/catalog_service/delete_entry_link.rb",
"snippets/catalog_service/delete_entry_type.rb",
"snippets/catalog_service/delete_metadata_feed.rb",
"snippets/catalog_service/get_aspect_type.rb",
"snippets/catalog_service/get_entry.rb",
"snippets/catalog_service/get_entry_group.rb",
"snippets/catalog_service/get_entry_link.rb",
"snippets/catalog_service/get_entry_type.rb",
"snippets/catalog_service/get_metadata_feed.rb",
"snippets/catalog_service/get_metadata_job.rb",
"snippets/catalog_service/list_aspect_types.rb",
"snippets/catalog_service/list_entries.rb",
"snippets/catalog_service/list_entry_groups.rb",
"snippets/catalog_service/list_entry_types.rb",
"snippets/catalog_service/list_metadata_feeds.rb",
"snippets/catalog_service/list_metadata_jobs.rb",
"snippets/catalog_service/lookup_context.rb",
"snippets/catalog_service/lookup_entry.rb",
"snippets/catalog_service/lookup_entry_links.rb",
"snippets/catalog_service/search_entries.rb",
"snippets/catalog_service/update_aspect_type.rb",
"snippets/catalog_service/update_entry.rb",
"snippets/catalog_service/update_entry_group.rb",
"snippets/catalog_service/update_entry_link.rb",
"snippets/catalog_service/update_entry_type.rb",
"snippets/catalog_service/update_metadata_feed.rb",
"snippets/cmek_service/create_encryption_config.rb",
"snippets/cmek_service/delete_encryption_config.rb",
"snippets/cmek_service/get_encryption_config.rb",
"snippets/cmek_service/list_encryption_configs.rb",
"snippets/cmek_service/update_encryption_config.rb",
"snippets/content_service/create_content.rb",
"snippets/content_service/delete_content.rb",
"snippets/content_service/get_content.rb",
"snippets/content_service/get_iam_policy.rb",
"snippets/content_service/list_content.rb",
"snippets/content_service/set_iam_policy.rb",
"snippets/content_service/test_iam_permissions.rb",
"snippets/content_service/update_content.rb",
"snippets/data_product_service/create_data_asset.rb",
"snippets/data_product_service/create_data_product.rb",
"snippets/data_product_service/delete_data_asset.rb",
"snippets/data_product_service/delete_data_product.rb",
"snippets/data_product_service/get_data_asset.rb",
"snippets/data_product_service/get_data_product.rb",
"snippets/data_product_service/list_data_assets.rb",
"snippets/data_product_service/list_data_products.rb",
"snippets/data_product_service/update_data_asset.rb",
"snippets/data_product_service/update_data_product.rb",
"snippets/data_scan_service/create_data_scan.rb",
"snippets/data_scan_service/delete_data_scan.rb",
"snippets/data_scan_service/generate_data_quality_rules.rb",
Expand All @@ -231,34 +245,28 @@
"snippets/data_taxonomy_service/update_data_taxonomy.rb",
"snippets/dataplex_service/cancel_job.rb",
"snippets/dataplex_service/create_asset.rb",
"snippets/dataplex_service/create_environment.rb",
"snippets/dataplex_service/create_lake.rb",
"snippets/dataplex_service/create_task.rb",
"snippets/dataplex_service/create_zone.rb",
"snippets/dataplex_service/delete_asset.rb",
"snippets/dataplex_service/delete_environment.rb",
"snippets/dataplex_service/delete_lake.rb",
"snippets/dataplex_service/delete_task.rb",
"snippets/dataplex_service/delete_zone.rb",
"snippets/dataplex_service/get_asset.rb",
"snippets/dataplex_service/get_environment.rb",
"snippets/dataplex_service/get_job.rb",
"snippets/dataplex_service/get_lake.rb",
"snippets/dataplex_service/get_task.rb",
"snippets/dataplex_service/get_zone.rb",
"snippets/dataplex_service/list_asset_actions.rb",
"snippets/dataplex_service/list_assets.rb",
"snippets/dataplex_service/list_environments.rb",
"snippets/dataplex_service/list_jobs.rb",
"snippets/dataplex_service/list_lake_actions.rb",
"snippets/dataplex_service/list_lakes.rb",
"snippets/dataplex_service/list_sessions.rb",
"snippets/dataplex_service/list_tasks.rb",
"snippets/dataplex_service/list_zone_actions.rb",
"snippets/dataplex_service/list_zones.rb",
"snippets/dataplex_service/run_task.rb",
"snippets/dataplex_service/update_asset.rb",
"snippets/dataplex_service/update_environment.rb",
"snippets/dataplex_service/update_lake.rb",
"snippets/dataplex_service/update_task.rb",
"snippets/dataplex_service/update_zone.rb",
Expand All @@ -284,9 +292,10 @@
"test/google/cloud/dataplex/v1/cmek_service_paths_test.rb",
"test/google/cloud/dataplex/v1/cmek_service_rest_test.rb",
"test/google/cloud/dataplex/v1/cmek_service_test.rb",
"test/google/cloud/dataplex/v1/content_service_paths_test.rb",
"test/google/cloud/dataplex/v1/content_service_rest_test.rb",
"test/google/cloud/dataplex/v1/content_service_test.rb",
"test/google/cloud/dataplex/v1/data_product_service_operations_test.rb",
"test/google/cloud/dataplex/v1/data_product_service_paths_test.rb",
"test/google/cloud/dataplex/v1/data_product_service_rest_test.rb",
"test/google/cloud/dataplex/v1/data_product_service_test.rb",
"test/google/cloud/dataplex/v1/data_scan_service_operations_test.rb",
"test/google/cloud/dataplex/v1/data_scan_service_paths_test.rb",
"test/google/cloud/dataplex/v1/data_scan_service_rest_test.rb",
Expand All @@ -305,6 +314,7 @@
"test/helper.rb"
],
"static": [
".OwlBot.yaml"
".OwlBot.yaml",
".owlbot.rb"
]
}
28 changes: 28 additions & 0 deletions google-cloud-dataplex-v1/.owlbot.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# (b/501191424): Manual removal of empty ContentService files since it contains no RPC definitions,
# preventing gRPC from generating a Stub class for it. To be removed once bug is fixed upstream.
FileUtils.rm_rf File.join(OwlBot.staging_dir, "lib", "google", "cloud", "dataplex", "v1", "content_service")
FileUtils.rm_f File.join(OwlBot.staging_dir, "lib", "google", "cloud", "dataplex", "v1", "content_service.rb")
FileUtils.rm_f File.join(OwlBot.staging_dir, "test", "google", "cloud", "dataplex", "v1", "content_service_test.rb")
FileUtils.rm_f File.join(OwlBot.staging_dir, "test", "google", "cloud", "dataplex", "v1", "content_service_paths_test.rb")
FileUtils.rm_f File.join(OwlBot.staging_dir, "test", "google", "cloud", "dataplex", "v1", "content_service_rest_test.rb")

OwlBot.modifier path: "lib/google/cloud/dataplex/v1.rb" do |content|
content.sub!(/require "google\/cloud\/dataplex\/v1\/content_service"\n/, "")
content
end

OwlBot.move_files
7 changes: 5 additions & 2 deletions google-cloud-dataplex-v1/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ source "https://rubygems.org"

gemspec

gem "google-style", "~> 1.31.1"
gem "minitest", "~> 5.22"
gem "google-style", "~> 1.32.0"
gem "irb", "~> 1.17"
gem "minitest", "~> 6.0.2"
gem "minitest-focus", "~> 1.4"
gem "minitest-mock", "~> 5.27"
gem "minitest-rg", "~> 5.3"
gem "ostruct", "~> 0.5.5"
gem "rake", ">= 13.0"
gem "redcarpet", "~> 3.6"
gem "yard", "~> 0.9"
120 changes: 74 additions & 46 deletions google-cloud-dataplex-v1/gapic_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,36 +144,6 @@
"methods": [
"cancel_job"
]
},
"CreateEnvironment": {
"methods": [
"create_environment"
]
},
"UpdateEnvironment": {
"methods": [
"update_environment"
]
},
"DeleteEnvironment": {
"methods": [
"delete_environment"
]
},
"ListEnvironments": {
"methods": [
"list_environments"
]
},
"GetEnvironment": {
"methods": [
"get_environment"
]
},
"ListSessions": {
"methods": [
"list_sessions"
]
}
}
}
Expand Down Expand Up @@ -403,15 +373,55 @@
"create_entry_link"
]
},
"UpdateEntryLink": {
"methods": [
"update_entry_link"
]
},
"DeleteEntryLink": {
"methods": [
"delete_entry_link"
]
},
"LookupEntryLinks": {
"methods": [
"lookup_entry_links"
]
},
"LookupContext": {
"methods": [
"lookup_context"
]
},
"GetEntryLink": {
"methods": [
"get_entry_link"
]
},
"CreateMetadataFeed": {
"methods": [
"create_metadata_feed"
]
},
"GetMetadataFeed": {
"methods": [
"get_metadata_feed"
]
},
"ListMetadataFeeds": {
"methods": [
"list_metadata_feeds"
]
},
"DeleteMetadataFeed": {
"methods": [
"delete_metadata_feed"
]
},
"UpdateMetadataFeed": {
"methods": [
"update_metadata_feed"
]
}
}
}
Expand Down Expand Up @@ -455,45 +465,63 @@
"clients": {
"grpc": {
"libraryClient": "::Google::Cloud::Dataplex::V1::ContentService::Client",
"rpcs": {}
}
}
},
"DataProductService": {
"clients": {
"grpc": {
"libraryClient": "::Google::Cloud::Dataplex::V1::DataProductService::Client",
"rpcs": {
"CreateContent": {
"CreateDataProduct": {
"methods": [
"create_data_product"
]
},
"DeleteDataProduct": {
"methods": [
"delete_data_product"
]
},
"GetDataProduct": {
"methods": [
"create_content"
"get_data_product"
]
},
"UpdateContent": {
"ListDataProducts": {
"methods": [
"update_content"
"list_data_products"
]
},
"DeleteContent": {
"UpdateDataProduct": {
"methods": [
"delete_content"
"update_data_product"
]
},
"GetContent": {
"CreateDataAsset": {
"methods": [
"get_content"
"create_data_asset"
]
},
"GetIamPolicy": {
"UpdateDataAsset": {
"methods": [
"get_iam_policy"
"update_data_asset"
]
},
"SetIamPolicy": {
"DeleteDataAsset": {
"methods": [
"set_iam_policy"
"delete_data_asset"
]
},
"TestIamPermissions": {
"GetDataAsset": {
"methods": [
"test_iam_permissions"
"get_data_asset"
]
},
"ListContent": {
"ListDataAssets": {
"methods": [
"list_content"
"list_data_assets"
]
}
}
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-dataplex-v1/google-cloud-dataplex-v1.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Gem::Specification.new do |gem|
["README.md", "LICENSE.md", "AUTHENTICATION.md", ".yardopts"]
gem.require_paths = ["lib"]

gem.required_ruby_version = ">= 3.1"
gem.required_ruby_version = ">= 3.2"

gem.add_dependency "gapic-common", "~> 1.2"
gem.add_dependency "google-cloud-errors", "~> 1.0"
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-dataplex-v1/lib/google/cloud/dataplex/v1.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
require "google/cloud/dataplex/v1/business_glossary_service"
require "google/cloud/dataplex/v1/catalog_service"
require "google/cloud/dataplex/v1/cmek_service"
require "google/cloud/dataplex/v1/content_service"
require "google/cloud/dataplex/v1/data_product_service"
require "google/cloud/dataplex/v1/data_taxonomy_service"
require "google/cloud/dataplex/v1/data_scan_service"
require "google/cloud/dataplex/v1/metadata_service"
Expand Down
Loading
Loading