Skip to content

chore: run bidi_tests independently#1781

Open
chandra-siri wants to merge 3 commits intomainfrom
fix_bidi_conformance_test
Open

chore: run bidi_tests independently#1781
chandra-siri wants to merge 3 commits intomainfrom
fix_bidi_conformance_test

Conversation

@chandra-siri
Copy link
Collaborator

@chandra-siri chandra-siri commented Mar 20, 2026

chore: run bidi conformance tests independently.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Mar 20, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the execution of conformance tests within the noxfile.py configuration. The primary goal is to ensure that bidirectional read and write tests are run as distinct processes, improving test isolation and clarity. This change also updates how the presence of conformance tests is verified before execution.

Highlights

  • Independent Bidirectional Tests: The conftest_retry Nox session was updated to run test_bidi_reads.py and test_bidi_writes.py independently, ensuring these specific bidirectional conformance tests are executed separately from the main conformance test suite.
  • Refined Conformance Test Check: The existence check for conformance tests in the conftest_retry session was refined to specifically look for tests/conformance/test_conformance.py instead of the entire conformance test folder.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the noxfile to run bidi tests independently. The changes are functional, but there's an opportunity to improve the code's maintainability by reducing duplication. I've suggested a refactoring that uses a loop to run the bidi tests, making the code more concise and easier to manage in the future.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@chandra-siri chandra-siri changed the title fix: run bidi_tests independently chore: run bidi_tests independently Mar 20, 2026
@chandra-siri chandra-siri marked this pull request as ready for review March 20, 2026 13:49
@chandra-siri chandra-siri requested review from a team as code owners March 20, 2026 13:49
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 20, 2026
@chandra-siri chandra-siri enabled auto-merge (squash) March 20, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants