Repository navigation
fix downloaded notebooks saved as invalid JSON - #201
Closed
DevDesai444 wants to merge 2 commits into
Closed
DevDesai444 wants to merge 2 commits into
DevDesai444 wants to merge 2 commits into
Conversation
The Contents API returns notebooks with format=json as a parsed dict. Using str() on this dict produces Python repr with single-quoted keys, which is not valid JSON. Downloaded notebooks could not be reopened. Use json.dumps() for the json format case so the output is valid JSON. Fixes googlecolab#190.
Adds test_download_json_format_writes_valid_json to confirm that notebooks returned with format=json round-trip through json.loads and match the original content dict.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
This looks great! If you sign the CLA I'll merge it. |
Collaborator
|
Still waiting on the you to sign the CLA |
Collaborator
|
#232 addresses the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colab downloadsaves notebooks with invalid Python repr instead of valid JSONformat: "json", the content is a parsed dict —str()produces single-quoted keys which is not valid JSONelifforformat == "json"that usesjson.dumpsto serialize properlyTest plan
test_download_json_format_writes_valid_jsontotests/test_contents.pyjson.loadsand matches original content