Skip to content

refactor: remove colab console in favour of colab ssh - #205

Merged
sethtroisi merged 3 commits into
mainfrom
pm/1029-1807/t03-remove-colab-console
Nov 10, 2026
Merged

sethtroisi merged 3 commits into
mainfrom
pm/1029-1807/t03-remove-colab-console

Conversation

@wh1ter4bb1t-js

Copy link
Copy Markdown
Member

why? colab ssh -s NAME -- CMD (#195) had to land first, since it replaces the shipped colab-operator skill's piping into colab console and keeps the exit status; echo '!cmd' | colab exec runs in the kernel and drops it (!false still exits 0).

Interactive users have colab ssh -s NAME. Breaking, so it needs a major version.

`colab ssh` supersedes the `/colab/tty` console, whose piped output carried
terminal-control bytes. This deletes the console module, its tests, the
piped-console integration test and converter.py's stale console comment.

Use `colab ssh -s NAME` for an interactive shell and
`colab ssh -s NAME -- CMD` for one-shot commands, or
`echo '!cmd' | colab exec -s NAME` where ssh can't work.

BREAKING CHANGE: `colab console` is removed; use `colab ssh -s NAME`, or `colab ssh -s NAME -- CMD` for one-shot commands (`!`-prefixed `colab exec` where ssh can't work).
…or code

The `!echo hi` passthrough test now sits next to the other `colab exec`
stdin tests and uses their runtime fixture. The console regression test
drops a docstring that restated it and checks Click's named usage-error
exit code instead of a bare 2.

@sethtroisi sethtroisi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, I want to cut a minor release first so I'm going to hold on on merging for a few days.

@wh1ter4bb1t-js wh1ter4bb1t-js changed the title refactor!: remove colab console in favour of colab ssh refactor: remove colab console in favour of colab ssh Nov 3, 2026
@sethtroisi
sethtroisi merged commit 6045e34 into main Nov 10, 2026
7 checks passed
@sethtroisi
sethtroisi deleted the pm/1029-1807/t03-remove-colab-console branch November 10, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants