subsetmerger.py: use filelock to prevent race condition while downloading#1182
Open
RickyDaMa wants to merge 3 commits intogooglefonts:mainfrom
Open
subsetmerger.py: use filelock to prevent race condition while downloading#1182RickyDaMa wants to merge 3 commits intogooglefonts:mainfrom
subsetmerger.py: use filelock to prevent race condition while downloading#1182RickyDaMa wants to merge 3 commits intogooglefonts:mainfrom
Conversation
The first branch already checks if the path exists, so there's no need to do it again This saves having to define an unneeded lockfile path for the case of local subset sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1181
filelockis already a transitive dependency, so this isn't adding a new dependency.I moved the download code path under the original conditional as in the
isinstance(upstream, str) and upstream not in SUBSET_SOURCESbranch, the file's existence has already been checked and the download is never needed, and so we don't need a lockfile. This also fixes "potentially unbound variable" lints forrepo&ref.