Repository navigation
build(deps): upgrade xgolsw to v0.23.0 - #3769
Conversation
Use the latest language-server fixes and register server disposal for in-process Worker tests so completed tests release project data and host callbacks. Verify that disposed instances reject subsequent messages. Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3769 +/- ##
=======================================
Coverage 59.96% 59.96%
=======================================
Files 772 772
Lines 27728 27728
Branches 5231 5231
=======================================
Hits 16628 16628
Misses 9586 9586
Partials 1514 1514
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review summary
This PR upgrades github.com/goplus/xgolsw from v0.22.2-0.20261110135259-6a3fc5aa0e59 to v0.23.0, which adds a new dispose() method to the XGoLanguageServer API, and adds test coverage that disposes in-process WASM server instances when a test finishes. Scope is clean and well-contained: a dependency bump, type declarations, and test-only code.
I reviewed for code quality, performance/resource handling, security, and documentation accuracy. Highlights:
- Correctly scoped disposal. Not calling
dispose()in the productionworker.tsrestart path is appropriate:startLS()only runs from thestoppedstate, which is reached after the previous Go WASM runtime has already exited (go.run(instance).finally(onStopped)), and normal teardown already destroys the whole worker viaworker.terminate().dispose()is needed only for the in-process test harness, which shares one JS realm — exactly where this PR applies it. - Security / supply chain: clean. The
v0.23.0go.sumzip andgo.modhashes match the public checksum database. The unchanged/go.modhash across versions is expected (that hash covers only thego.modbytes), while the source (zip) hash did change. No transitive-dependency drift. dispose()JSDoc and the new inline test comments are accurate and consistent with howworker.test.tsexercises the API (handleMessagereturnsnullbefore disposal, anErrorafter).
One minor documentation nit is noted inline. Otherwise this looks good to merge.
Use the latest language-server fixes and register server disposal for in-process Worker tests so completed tests release project data and host callbacks.
Verify that disposed instances reject subsequent messages.