Skip to content

build(deps): upgrade xgolsw to v0.23.0 - #3769

Merged
nighca merged 1 commit into
goplus:devfrom
aofei:upgrade-xgolsw
Nov 13, 2026
Merged

nighca merged 1 commit into
goplus:devfrom
aofei:upgrade-xgolsw

Conversation

@aofei

@aofei aofei commented Nov 13, 2026

Copy link
Copy Markdown
Member

Use the latest language-server fixes and register server disposal for in-process Worker tests so completed tests release project data and host callbacks.

Verify that disposed instances reject subsequent messages.

Use the latest language-server fixes and register server disposal for
in-process Worker tests so completed tests release project data and host
callbacks.

Verify that disposed instances reject subsequent messages.

Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.96%. Comparing base (7bb2013) to head (750a9b3).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3769   +/-   ##
=======================================
  Coverage   59.96%   59.96%           
=======================================
  Files         772      772           
  Lines       27728    27728           
  Branches     5231     5231           
=======================================
  Hits        16628    16628           
  Misses       9586     9586           
  Partials     1514     1514           
Flag Coverage Δ
gui 59.44% <ø> (ø)
tools-ai 79.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

This PR upgrades github.com/goplus/xgolsw from v0.22.2-0.20261110135259-6a3fc5aa0e59 to v0.23.0, which adds a new dispose() method to the XGoLanguageServer API, and adds test coverage that disposes in-process WASM server instances when a test finishes. Scope is clean and well-contained: a dependency bump, type declarations, and test-only code.

I reviewed for code quality, performance/resource handling, security, and documentation accuracy. Highlights:

  • Correctly scoped disposal. Not calling dispose() in the production worker.ts restart path is appropriate: startLS() only runs from the stopped state, which is reached after the previous Go WASM runtime has already exited (go.run(instance).finally(onStopped)), and normal teardown already destroys the whole worker via worker.terminate(). dispose() is needed only for the in-process test harness, which shares one JS realm — exactly where this PR applies it.
  • Security / supply chain: clean. The v0.23.0 go.sum zip and go.mod hashes match the public checksum database. The unchanged /go.mod hash across versions is expected (that hash covers only the go.mod bytes), while the source (zip) hash did change. No transitive-dependency drift.
  • dispose() JSDoc and the new inline test comments are accurate and consistent with how worker.test.ts exercises the API (handleMessage returns null before disposal, an Error after).

One minor documentation nit is noted inline. Otherwise this looks good to merge.

Comment thread tools/spxls/index.d.ts Resolved
@nighca
nighca merged commit fce3f1a into goplus:dev Nov 13, 2026
8 checks passed
@aofei
aofei deleted the upgrade-xgolsw branch November 13, 2026 02:44

This branch was successfully deployed

1 active deployment
Preview – builder — 750a9b3a Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants