fix: crash ui after opening BottomSheetModal with BottomSheetSectionList on Web 5.2.10 (#2662)#2663
Merged
gorhom merged 1 commit intoApr 29, 2026
Conversation
…ist on Web 5.2.10 (gorhom#2662)
gorhom
approved these changes
Apr 29, 2026
Owner
|
thanks @rozhkovs for submitting this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #2662
It turns out that
SectionListdoesn't have agetNativeScrollRefmethod, but it does have agetScrollableNodemethod. This solves the issue I referenced above.I'm actually not sure whether any changes are needed on this library's side. This seems more like a
react-native-webbug, but I don't quite understand why this method wasn't added. One related old issue. There may be some reasoning behind this that I'm not aware of.I would appreciate any feedback. If needed, I can refine these changes or open an issue/PR in the
react-native-weblibrary.