Skip to content

cross mount#101

Merged
ArtiomTr merged 3 commits into
grandinetech:devnet-4from
bomanaps:fix/cross-mount-git-dir
May 13, 2026
Merged

cross mount#101
ArtiomTr merged 3 commits into
grandinetech:devnet-4from
bomanaps:fix/cross-mount-git-dir

Conversation

@bomanaps
Copy link
Copy Markdown
Contributor

No description provided.

@bomanaps
Copy link
Copy Markdown
Contributor Author

Comment thread lean_client/Makefile Outdated
# Repo root that cross bind-mounts into its build container (see
# `lean_client/Cross.toml`). Auto-derived locally; CI overrides via env.
LEAN_REPO_ROOT ?= $(shell git rev-parse --show-toplevel)
export LEAN_REPO_ROOT
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a bit of an anti-pattern to mutate global environment, so probably better to inline env near the scripts:

./target/x86_64-unknown-linux-gnu/release/lean_client:
	LEAN_REPO_ROOT=$(LEAN_REPO_ROOT) cross build --bin lean_client --target x86_64-unknown-linux-gnu --profile release

same with other one

@bomanaps bomanaps requested a review from ArtiomTr May 13, 2026 16:01
@ArtiomTr ArtiomTr merged commit c6fbddd into grandinetech:devnet-4 May 13, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants