Repository navigation
fix(agents): report unimplemented MCP routes as failures and fail closed on VERA errors - #2713
Merged
Merged
Conversation
…sed on VERA errors
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| exc, | ||
| exc_info=True, | ||
| ) | ||
| return f"VERA: gateway check failed ({type(exc).__name__}) — stage blocked (fail-closed)" |
Contributor
Copilot started work to fix failing Actions workflows on behalf of
groupthinking
November 17, 2026 09:57
Copilot stopped work on behalf of
groupthinking due to an error
November 17, 2026 09:57
This was referenced Nov 17, 2026
Closed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Closes #2666
Outcome
Unimplemented MCP, internal, and HTTP routes in
MCPAgentNetworknow report explicitnot_implementedfailure envelopes (withexecuted: Falseand anerrorkey) instead of misleading"routed"/"pending_implementation"success states. Broken installed VERA components and failed VERA identity, gateway, or firewall checks now fail closed and block stage execution while recording structured failure proofs.Scope
src/agents/mcp_agent_network.py: explicitnot_implemented_resulthelper and failure responses for unconfigured MCP, internal, HTTP, skill-builder, knowledge-base, and deployment routes.src/agents/pipeline_orchestrator.py:VeraInitErrorfail-closed initialization when installed VERA modules fail to load,_stage_failure_reasonvalidation for non-dict andfailed/error/not_implementedstatuses, and fail-closed exception boundaries across VERA credential issuance/verification, gateway checks, and firewall scans.tests/unit/test_mcp_routed_false_success_2168.py: 23 unit regression tests covering unimplemented routes, pipeline stage failure reporting, and VERA fail-closed boundaries using canonical fixtureauJzb1D-fag.vercel.json/apps/web/vercel.jsondeployment-disabling overrides from draft PR fix(agents): report unimplemented MCP routes as failures and fail closed on VERA errors #2628.except Exceptionpatterns; add structured error handling #2168 outside this bounded slice.Risk
main.Verification
PYTHONPATH=src pytest tests/unit/test_mcp_routed_false_success_2168.py -v: 23 passed; 151 passed across related orchestration/deployment suites;python3 -m compileall -q src/)Production evidence
Vercel preview and E2E pipeline checks run automatically against this PR head.
Agent handoff