Skip to content

fix(agents): report unimplemented MCP routes as failures and fail closed on VERA errors - #2713

Merged
groupthinking merged 1 commit into
mainfrom
fix/2666-mcp-routed-false-success
Nov 17, 2026
Merged

groupthinking merged 1 commit into
mainfrom
fix/2666-mcp-routed-false-success

Conversation

@groupthinking

Copy link
Copy Markdown
Owner

Canonical issue

Closes #2666

Outcome

Unimplemented MCP, internal, and HTTP routes in MCPAgentNetwork now report explicit not_implemented failure envelopes (with executed: False and an error key) instead of misleading "routed" / "pending_implementation" success states. Broken installed VERA components and failed VERA identity, gateway, or firewall checks now fail closed and block stage execution while recording structured failure proofs.

Scope

  • Included:
    • src/agents/mcp_agent_network.py: explicit not_implemented_result helper and failure responses for unconfigured MCP, internal, HTTP, skill-builder, knowledge-base, and deployment routes.
    • src/agents/pipeline_orchestrator.py: VeraInitError fail-closed initialization when installed VERA modules fail to load, _stage_failure_reason validation for non-dict and failed/error/not_implemented statuses, and fail-closed exception boundaries across VERA credential issuance/verification, gateway checks, and firewall scans.
    • tests/unit/test_mcp_routed_false_success_2168.py: 23 unit regression tests covering unimplemented routes, pipeline stage failure reporting, and VERA fail-closed boundaries using canonical fixture auJzb1D-fag.
  • Explicitly excluded:

Risk

  • Risk level: low
  • Failure mode: Pipeline stages that previously relied on silent pass-through when VERA raised internal exceptions or when an unimplemented MCP route was invoked will now explicitly report failure.
  • Rollback: Revert this squash commit on main.

Verification

  • Focused tests (PYTHONPATH=src pytest tests/unit/test_mcp_routed_false_success_2168.py -v: 23 passed; 151 passed across related orchestration/deployment suites; python3 -m compileall -q src/)
  • Required CI
  • Review threads resolved

Production evidence

Vercel preview and E2E pipeline checks run automatically against this PR head.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Nov 17, 2026 9:31am UTC

exc,
exc_info=True,
)
return f"VERA: gateway check failed ({type(exc).__name__}) — stage blocked (fail-closed)"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERA identity, gateway, and firewall exceptions now block stages without recording their rejection in the tamper-evident proof chain.

Fix on Vercel

@groupthinking
groupthinking merged commit ef4f116 into main Nov 17, 2026
39 of 41 checks passed
@groupthinking
groupthinking deleted the fix/2666-mcp-routed-false-success branch November 17, 2026 09:57
Copilot stopped work on behalf of groupthinking due to an error November 17, 2026 09:57

This branch was successfully deployed

1 active deployment
Preview — 01671d48 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail closed on unimplemented MCP routes and verifier errors

2 participants