Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @guansss,
In the last year I've performed a lot of improvements on this repo:
preparelifecycle script and moves the package entry-point paths fromlib/todist/lib/. Now you can install it directly from GitHub:refactor: upgrade to webpack-dev-server 5 and webpack-cli 7 —> Closes "match" in meta file didn't support port #4. Upgrades the dependencies and drops some that are no longer used.
chore: simplify build scripts —> removes some scripts that are no longer used, and fixes a bug introduced by changing the package paths.
ci: add dependabot and CI workflow —> adds dependabot to keep the dependencies updated, and adds CI for lint and static tests.
refactor: migrate case-test suite and snapshots —> changes the tests to be native-Node compatible, and rewrites the Playwright suite that had been broken for a long time. I took the occasion to add Tampermonkey as a testing extension.
fix: escape backticks in inlined CSS —> Closes Unescaped "`" in CSS Loading #5. A simple missing escape.
fix: define MK_GLOBAL fallback for style-loader CSS —> Closes __MK_GLOBAL__ is not defined on adding css. #8. Adds a guard so style-loader works too.
docs: update examples and documentation —> updates the README and DEVELOPMENT guide, and rebuilds the examples.
feat: warn when a strict CSP blocks the dev client — unfortunately we can't work around a strict CSP (e.g.
default-src 'self'without'unsafe-eval'): it blocks theeval()the dev client uses to evaluate the fetched bundles. So I've added a warning that suggests the workaround (disable the page's CSP with a browser extension during development).