Fix async method tracing#1
Merged
Merged
Conversation
|
🚅 Deployed to the container-pr-1 environment in 😸 ray.cat
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

With
@Service({ trace: true }), async methods were not getting traced correctly.wrapWithTracingis passing a synccallback () => original.apply(this, args)to the trace function for all methods, including async ones. Some tracer fns (e.g. DD APM'stracer.trace) closes the span immediately when the callback returns synchronously even if the retval is a Promise.This fixes it by detecting
AsyncFunctionmethods and passasync () => original.apply(this, args)so tracing libraries that inspect the callback's constructor (DD APM, OpenTelemetry) keep the span open until the promise settles.