Skip to content

FE-744: Document Pi command containment evidence#150

Merged
lunelson merged 164 commits into
nextfrom
ln/fe-744-pi-ui-extension-patterns
Jun 2, 2026
Merged

FE-744: Document Pi command containment evidence#150
lunelson merged 164 commits into
nextfrom
ln/fe-744-pi-ui-extension-patterns

Conversation

@lunelson
Copy link
Copy Markdown
Contributor

FE-744: Document Pi command containment evidence

FE-744: Prove dynamic Brunch chrome wrapper

restore provisional plan

FE-744: Refresh provisional Pi UI handoff

Tighten ln-build artifact cleanup guardrails

capture brunch ANSI logo exploration and decision

FE-744: Add workspace launch inventory

FE-744: Activate workspace switch decisions

FE-744: Add workspace switcher decision UI

FE-744: Gate TUI startup on workspace switch

FE-744: Rename implicit coordinator operations

FE-744: Split coordinator caller interfaces

FE-744: Remove source-string boundary tests

FE-744: Require activated chrome session state

FE-744: Narrow coordinator test doubles

FE-744: Route fixture capture through RPC handlers

FE-744: Extract Brunch Pi extension entrypoint

FE-744: Split workspace switcher modules

FE-744: Replace shell source test with helpers

FE-744: Fix offline default env typing

FE-744: Retire exhausted refactor queue

FE-744: Split Brunch extension surfaces

FE-744: Allocate Brunch chrome surfaces

FE-744: Add in-session workspace switch command

FE-744: Add startup no-resume oracle

FE-744: Reconcile Pi UI extension memo

@lunelson lunelson marked this pull request as ready for review May 27, 2026 16:31
@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Low Risk
Changes are predominantly documentation, agent skills, and fixture relocation with no core auth or data-path logic in the diff; the CLI wrapper change is localized exit/error handling.

Overview
This PR reshapes agent workflow docs more than application runtime code. It adds a full pseudo skill (tree/chain/graph/matrix/state-machine/data-shape/lanes) and wires notation aids into ln-spec, ln-design, ln-scope, ln-plan, ln-refactor, ln-sync, ln-build, and ln-judo-review. ln-consult, ln-plan, ln-design, and ln-scope now prefer tracer-bullet slices (proof of life, invariants, uncertainty) over default spikes, with tighter assumption gates and ln-build cleanup that only auto-deletes exhausted memory/CARDS.md while requiring review before other volatile docs.

Verification layout moves from the retired brief-library .brunch-fixtures/ tree to .fixtures/runs/<probe-id>/<run-id>/ with session.jsonl, transcript.md, and report.json, including a committed public-rpc-parity run; docs/README.md and architecture docs point at probes-and-transcripts.md instead of fixture-strategy.md.

Smaller repo changes: AGENTS.md adds an explicit do-not-delete untracked/uncommitted work rule; bin/brunch.js wraps runBrunchCli() with proper exit codes; formatter/linter ignore patterns follow .fixtures; vendored @types/*_configuration_schema.json files are added.

Reviewed by Cursor Bugbot for commit 782626d. Bugbot is set up for automated code reviews on this repo. Configure here.

@lunelson lunelson marked this pull request as draft May 27, 2026 16:31
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 27, 2026

This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it.

@lunelson lunelson marked this pull request as ready for review June 2, 2026 08:17
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Jun 2, 2026

🤖 Augment PR Summary

Summary: Documents Pi command-containment evidence and tightens the Brunch↔Pi UI extension boundary, while adding an explicit workspace/spec/session selection flow for TUI startup and in-session switching.

Changes:

  • Adds a new pseudo skill (+ reference docs) and updates multiple ln-* skills to preserve/use pseudo artifacts for trees/graphs/chains/matrices/state-machines/data-shapes/lanes.
  • Tightens ln-build artifact cleanup guardrails to avoid deleting future-facing handoff/provisional docs by default.
  • Refactors workspace session coordination to expose workspace inventory plus explicit activation decisions (continue/open/new session/new spec/cancel).
  • Adds a TUI workspace switcher dialog/command and gates interactive startup on the chosen workspace decision.
  • Plumbs workspace activation through JSON-RPC handlers and snapshots for Pi UI consumers.
  • Introduces Brunch resource-loader/settings helpers and applies an offline default for TUI runs.
  • Splits TypeScript configs (typecheck-only tsconfig.json vs emitting tsconfig.build.json) and updates tests accordingly.

Technical Notes: Workspace inventory surfaces unavailable sessions with explicit reasons and activation updates .brunch/state.json to reflect the selected spec/session.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

type InspectedSessionFile = WorkspaceLaunchSession | WorkspaceUnavailableSession

async function inspectSessionFile(file: string): Promise<InspectedSessionFile> {
const entries = await readJsonl(file)
Copy link
Copy Markdown

@augmentcode augmentcode Bot Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspectSessionFile() calls readJsonl() which JSON.parses every line; a single corrupted/partial session file will throw and abort inventory/activation, which can crash the CLI instead of just treating that session as unavailable. Consider catching parse errors and returning an unavailable entry/reason (also applies to the readJsonl() usage in verifyWorkspaceSessionStores()).

Severity: medium

Other Locations
  • src/workspace-session-coordinator.ts:631

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@lunelson lunelson self-assigned this Jun 2, 2026
@lunelson lunelson requested a review from kostandinang June 2, 2026 13:35
@graphite-app graphite-app Bot changed the base branch from ln/fe-737-web-shell to graphite-base/150 June 2, 2026 17:34
lunelson and others added 21 commits June 2, 2026 17:50
new pseudo skill: minimal notation typology for human-agent design
(tree, chain, graph, matrix, state-machine, data-shape, lanes) with
shared overlay grammar (#anchor, @owner, +/-/~/!/?, ->/~>/x>) and a
routing chain expressed in its own chain notation.

cross-link directives in ln-{spec,design,scope,plan,refactor,review,
sync,build} using a grep-able **Notation aid.** lead-in.

ln-sync directive explicitly preserves existing pseudo artifacts and
consolidates qualifying prose into them, so future sync runs do not
collapse pseudo back to prose.

PLAN.md updates as living examples:
- Dependencies block: hand-drawn tree -> pseudo graph with cross-edges
  (m5 -[optional]-> subagents, graph-plane -[on promotion]-> oracle)
  visible and horizon items grouped under unconnected
- agent-graph-integration acceptance: paragraph -> pseudo tree
  (obligation decomposition) with each leaf individually testable
@lunelson lunelson force-pushed the ln/fe-744-pi-ui-extension-patterns branch from 7e85986 to 782626d Compare June 2, 2026 17:50
@lunelson lunelson force-pushed the graphite-base/150 branch from eab91df to b28b964 Compare June 2, 2026 17:50
@graphite-app graphite-app Bot changed the base branch from graphite-base/150 to next June 2, 2026 17:50
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jun 2, 2026

Merge activity

  • Jun 2, 5:50 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@lunelson lunelson merged commit e3cae32 into next Jun 2, 2026
12 checks passed
@lunelson lunelson deleted the ln/fe-744-pi-ui-extension-patterns branch June 2, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant