Skip to content

Support redirect for head request for downloads #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessevz merged 2 commits into from
Mar 19, 2026
Merged

Support redirect for head request for downloads #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e7e6cb
Support redirect for head request for downloads
Mar 17, 2026
413b3f6
Simplified the status code check of the head request
Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions htpclient/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ def download(url, output, no_header=False):

# Check header
if not no_header:
head = session.head(url)
# not sure if we only should allow 200/301/302, but then it's present for sure
if head.status_code not in [200, 301, 302]:
head = session.head(url, allow_redirects=True)
if not head.ok:
logging.error("File download header reported wrong status code: " + str(head.status_code))
return False

Expand Down