Repository navigation
Fix misleading docstring on require_no_authentication - #5865
Merged
carlosantoniodasilva merged 2 commits intoOct 6, 2026
Merged
carlosantoniodasilva merged 2 commits into
carlosantoniodasilva merged 2 commits into
Conversation
The comment said 'no authentication is required', which reads as 'either state is fine'. The method actually enforces the opposite: the user must NOT be authenticated, redirecting already-signed-in users away. Comment-only fix; method name and behavior are unchanged.
Signed-off-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5559.
The comment above
require_no_authenticationsaid it was for actions "where no authentication is required", which reads as "signed in or not, either is fine". The method does the opposite: it requires that the user is not signed in, and redirects a signed-in user away. This changes the comment only. The method name and behaviour are unchanged; the rename floated in the issue would break the public API, so it's left out.Tested:
bin/teston the branch, 878 runs, 2470 assertions, 0 failures, 0 errors, 0 skips.Written with an AI coding assistant (Claude Code). The diff was reviewed and
bin/testpassed (878 runs, 0 failures) before submission.