Repository navigation
Pin json < 3 for the Rails 7.0, 7.1 and 8.0 gemfiles - #5866
Merged
Merged
Conversation
Active Support in these versions still passes `quirks_mode` to JSON.generate, which json 3.0 removed, so every request that renders a view fails with `unknown keyword: quirks_mode` in CI. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Active Support in Rails 7.0, 7.1 and 8.0 still passes
quirks_modetoJSON.generate, which json 3.0 removed. The gemfiles for those versions have no upper bound onjson, so a freshbundle installnow resolves json 3.x and every test that renders a view fails with:This pins
json < 3in the three affected gemfiles only. Rails 7.2+ no longer passesquirks_mode, so those gemfiles are untouched.CI on the fork with this change: https://github.com/excid3/devise/actions/runs/37405511101
🤖 Generated with Claude Code
https://claude.ai/code/session_01Fb2E5SnkxkicWdSSbqUN4y