Repository navigation
Fix test suite deprecations and failure on Rails main (8.2) - #5867
Merged
Merged
Conversation
* `action_methods` now returns a frozen Set, so use `reject` instead of `delete_if` in the internal helpers test. * `Mime::SET` is deprecated in favor of `Mime.symbols`. * `protect_from_forgery` without a strategy is deprecated; pass the current default explicitly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small test-suite fixes so the
rails-mainCI job (Rails 8.2) passes again. No library changes.AbstractController::Base.action_methodsnow returns a frozenSet, sointernal_helpers_test.rbfails withFrozenErrorondelete_if. Userejectinstead.Mime::SETis deprecated in favor ofMime.symbols, which older supported Rails versions don't have. The test app'sApplicationControllerpicks whichever is available.protect_from_forgerywithout a strategy is deprecated in 8.2; the test app now passes the current default (with: :null_session) explicitly.The one remaining 8.2 deprecation in the suite comes from
lib,Mime::EXTENSION_LOOKUPinDeviseController#navigational_formats, which #5856 already fixes.CI on the fork with this change: https://github.com/excid3/devise/actions/runs/37405513876
🤖 Generated with Claude Code
https://claude.ai/code/session_01Fb2E5SnkxkicWdSSbqUN4y