Repository navigation
Conversation
…n keys in flash messages Since heartcombo#5822, human_attribute_name values are downcased on the first letter for the failure flash message. For multi-word title-cased names like "Company Code" this produces "company Code", which reads like a typo. Only apply downcase_first to single-word names ("Email" -> "email"), preserving the original casing of multi-word names ("Company Code").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5864.
Since #5822,
human_attribute_namevalues are downcased on the first letter when interpolated into the failure flash message. For multi-word title-cased names like "Company Code" this produces "company Code", which reads like a typo:Before:
Invalid login ID and company Code or password.After:
Invalid Login ID and Company Code or password.This change only applies
downcase_firstto single-word names ("Email" -> "email", keeping #4834's grammar fix and #5822's German "E-Mail" behavior), while multi-word names keep their original casing.A regression test was added to
test/failure_app_test.rbcovering a multi-word translated attribute name; the existing single-word expectations ("Invalid email or password.") are unchanged.