Repository navigation
Conversation
Contributor
|
Contributor
Author
|
Consolidated into #124, the single Unified Scroll runtime lifecycle review against master. Verified this PR head is an ancestor of #124 and the combined GitHub diff matches the full local lifecycle diff. Closing as superseded, not merged; code, commits, branch and discussion remain preserved. Continue review in #124. |
MarcStdt
added this pull request to stack #126
October 4, 2026 16:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of this layer
Carry installed-release state through Docker/Kubernetes workers; serialize runtime maintenance, stage restoration, handle rollback failures, and resume maintenance-stopped queues for the intended restart.
Review order
Review runtime maintenance state and backup/restore workers before backend plumbing. This layer implements feature-specific maintenance behavior; it does not claim to fix the excluded general active-workload stop/requeue and backup-ownership problems.
Native GitHub stack #126, bottom to top:
GitHub's Files changed tab is incremental against the preceding branch. Review the complete stack before landing: later layers contain final fixes and cleanup for earlier layers. The old consolidated/superseded descriptions and draft acceptance notes are historical and replaced by this reconstruction.
Unchanged implementation
Reconstructed from existing commits only: no source edits, rebases, squashes or force-pushes. The complete stack tip is
e4aadf2816bfec4f4642cf2ae130ca82401b5fd9, tree7d6c9fb61e07900ec756fef2437b495c230a4585, exactly the previously verified local tree. Existing commits, discussion and PR identities are retained; only the runtime update boundary needed a new PR.Verification and rollout
Local verification recorded on October 3 for the complete final implementation: 112 lifecycle/UI tests (11 opt-in skips in the default run); separate real Harbor/Postgres integration (2 passed); authenticated publisher import/retry/publication; SPA type-check; full CLI and engine commands; uncached publisher/workflow checks; focused race runs; rebuilt Docker/Kubernetes acceptance. Browser/workload evidence is complementary and qualified, not one uninterrupted end-to-end run. Four legacy Core compilation failures and the documented baseline active-workload backup/queue issues remain outside scope. These results do not assert every historical intermediate layer independently passed the final suite or that fresh remote CI is green.
See the final local requirement audit for exact commands, qualifications and rollout order. Ready for review does not mean merged or deployed. Matching Core/engine/runtime contracts must ship together; configure the public runtime API URL when GAME_HOST is not that API. Protected Team publishing environments/identity/secrets must exist before activating the workflow cutover; its fail-closed gate remains intact.
Companion changes: monorepo stack, runtime stack, standalone publisher. No production mutation or merge is part of this reconstruction.