Fix Windows canvas lockup: remove SetWindowPos from blit()

model/windowInformation.cc

@@ -82,7 +82,11 @@ namespace minsky
       HDC dc=BeginPaint(winfo.childWindowId, &ps);
       BitBlt(dc, x, y, width,height,winfo.hdcMem,x,y,SRCCOPY);
       EndPaint(winfo.childWindowId, &ps);
-      SetWindowPos(winfo.childWindowId,HWND_TOP,winfo.offsetLeft,winfo.offsetTop,winfo.childWidth,winfo.childHeight,0);
+      // Note: SetWindowPos was previously called here on every blit to keep the
+      // child window at HWND_TOP, but that fired WM_WINDOWPOSCHANGED on every
+      // paint which could cascade into further WM_PAINT messages and interact
+      // badly with screen-sharing hooks (e.g. Zoom).  The window is already
+      // positioned correctly at creation time in WindowInformation().
 #elif defined(USE_X11)
       static mutex blitting;
       const lock_guard<mutex> lock(blitting);
@@ -159,6 +163,12 @@ namespace minsky
           if (GetUpdateRect(hwnd,&r,false))
             blit(*winfo, r.left, r.top, r.right-r.left, r.bottom-r.top);
         }
+        else
+          // GWLP_USERDATA is zeroed in ~WindowInformation before the window is
+          // closed, so reaching here means the WindowInformation has already been
+          // torn down.  Validate the rect so Windows stops generating WM_PAINT
+          // messages for a window that no longer has a backing buffer.
+          ValidateRect(hwnd, nullptr);
         return 0;
       case WM_NCHITTEST:
         return HTTRANSPARENT;

schema/optional.h

@@ -77,7 +77,7 @@ namespace classdesc
   void xsd_generate(xsd_generate_t& g, const string& d, const minsky::Optional<T>& a) 
   {
     xsd_generate_t::Optional o(g,true);
-    T tmp; // a may be null
+    T tmp{}; // a may be null
     xsd_generate(g,d,tmp);
   }
 

test/testMinsky.cc

@@ -1270,7 +1270,7 @@ TEST(TensorOps, evalOpEvaluate)
 
       // renaming just the canvas variable should change  it's type
       canvas.item=stockVar;
-      if (auto v=canvas.item->variableCast())
+      if (canvas.item->variableCast())
         {
           canvas.renameItem("foo");
           EXPECT_TRUE(canvas.item && canvas.item->variableCast());

test/testPubTab.cc

@@ -157,7 +157,7 @@ TEST_F(PubTabSuite,removeSelf)
          load("1Free.mky");
          // send the Godley table to the pub tab
          for (auto& i: model->items)
-           if (auto g=dynamic_cast<GodleyIcon*>(i.get()))
+           if (dynamic_cast<GodleyIcon*>(i.get()))
              {
                publicationTabs[0].items.emplace_back(i);
                break;