Repository navigation
fix(verification): let the nightly provenance rebuild pass - #588
Merged
Merged
Conversation
must() compared runTool's outcome against a "succeeded" kind that runTool never returns, so every rebuild command failed, even a clone that exited 0. The nightly provenance job has not passed since #396. With that fixed, imsg's tip-commit check also failed because git am writes fresh committer metadata. Pin imsg's reconstructed source tree the same way wacli already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Nightly verification
messaging binary provenancejob, which has failed every night since #396.Root cause
must()inscripts/messaging-runtime-provenance.tscheckedoutcome.kind !== "succeeded", butrunToolonly returnsexited/timed-out/output-limit/signaled/spawn-failed. Every command failed, which is why the log reads "wacli clone failed (exited, exit code 0)". The job never reached a real rebuild.assertPatchStackIdentity:git amwrites new committer metadata, so the recordedtipCommit(533789…) can never be reproduced. wacli already pinssourceTreefor this reason. imsg now pinssourceTreeac999492…, recomputed by applying the four reviewed patches (theirFromheaders name the recorded tip, 533789…) to base 25beb76.Changes
commandSucceeded()(exited with code 0) and uses it inmust().sourceTreepin.Verification
bun test scripts/messaging-runtime-provenance.test.ts: 5 passbun run ./scripts/messaging-runtime-provenance.ts nightlylocally on macOS arm64: wacli rebuilt from pinned source matches the committed executable byte for byte; imsg's pinned recipe builds an arm64 executable.Utility
This is the only check that rebuilds the shipped wacli/imsg binaries from pinned upstream source plus the reviewed patches. Per-PR CI (
verify) only checks that the committed bytes match their own provenance records. Worth keeping.🤖 Generated with Claude Code