Skip to content

Modernize C++ database build and tests - #1

Merged
hskl18 merged 1 commit into
mainfrom
agent/modernize-cpp-db
Jul 12, 2026
Merged

hskl18 merged 1 commit into
mainfrom
agent/modernize-cpp-db

Conversation

@hskl18

@hskl18 hskl18 commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • modernize the project to CMake 3.20 and C++17 with a reusable static core library
  • replace false-positive tests with dependency-free behavioral coverage registered in CTest
  • fix batch paths, error state, persistence behavior, C++17 compatibility, and strict compiler warnings
  • add Linux/macOS CI, an MIT license, reproducible documentation, and repository hygiene

Verification

  • clean Release configure passes with CMAKE_COMPILE_WARNING_AS_ERROR=ON
  • strict Apple Clang build passes
  • CTest passes 1/1 with real create, insert, filter, persistence, fixture, and error assertions
  • git diff --check and git fsck --full pass

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@hskl18, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 639ed061-5560-4bec-a362-beb988e0ee85

📥 Commits

Reviewing files that changed from the base of the PR and between 0f06ba8 and 39e8697.

⛔ Files ignored due to path filters (2)
  • .DS_Store is excluded by !**/.DS_Store
  • includes/.DS_Store is excluded by !**/.DS_Store
📒 Files selected for processing (33)
  • .github/workflows/ci.yml
  • .gitignore
  • .idea/.gitignore
  • .idea/.name
  • .idea/misc.xml
  • .idea/vcs.xml
  • CMakeLists.txt
  • LICENSE
  • README.md
  • _tests/_test_files/basic_test.cpp
  • _tests/_test_files/test_batch1.cpp
  • _tests/_test_files/test_batch2.cpp
  • includes/binary_files/file_record.cpp
  • includes/binary_files/utilities.cpp
  • includes/binary_files/utilities.h
  • includes/linked_list/linked_list_functions/linked_list_functions.h
  • includes/linked_list/queue/MyQueue.h
  • includes/linked_list/stack/MyStack.h
  • includes/map/bplustree.h
  • includes/map/btree_array_functions.h
  • includes/map/map.h
  • includes/map/mmap.h
  • includes/map/mpair.h
  • includes/parser/parser.cpp
  • includes/shunting_yard/token.h
  • includes/sql/sql.cpp
  • includes/table/table.cpp
  • includes/table/table.h
  • includes/tokenizer/ftokenize.h
  • includes/tokenizer/state_machine_functions.cpp
  • includes/tokenizer/stokenize.cpp
  • includes/tokenizer/stokenize.h
  • tests/sql_tests.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/modernize-cpp-db

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hskl18
hskl18 merged commit d8c467f into main Jul 12, 2026
3 checks passed
@hskl18
hskl18 deleted the agent/modernize-cpp-db branch July 12, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant