Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rate limiter can crash the whole process when one IP sends several requests at once (for example, a question page with many images loading in parallel).
Cause: the per-IP counter is updated with a separate
LoadandStore, so simultaneous requests can lose increments. The count then reaches 0 while some 1-minute timers are still pending. One timer deletes the entry, and the next one runsval.(int)on a nil value and panics. The panic happens in a timer goroutine, sogin.Recovery()doesn't catch it and the process exits.Fix: the timer returns early if the entry is already gone.
Testing: sent bursts of 28 simultaneous requests from one IP and waited for the timers. Before the fix, the server crashed with
interface conversion: interface {} is nil, not int. After the fix, it stayed up in every run.