Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/healthzalways returns 503:https://stackoverflow.comredirects to a Cloudflare challenge (403), even when the app works fine withSCRAPER=api.With
SCRAPER=api, the healthcheck now pingshttps://api.stackexchange.com/docsinstead, since that's what the app depends on./docsdoesn't use API quota, unlike/2.3/*methods. A check every 60s would use up the 300/day anonymous quota on its own. The HTML scraper keeps pinging stackoverflow.com, since it depends on that. The unusedstackexchange.comcheck is removed.The Docker healthcheck binary ignored the status code, so the container showed as healthy even when
/healthzreturned 503. It now exits 1 on anything but 200.Tested:
/healthzreturns 200 withSCRAPER=api; the healthcheck binary exits 0 there, and 1 when/healthzreturns 503 or the app is down.