Ci test fixes#2079
Open
sebpop wants to merge 2 commits into
Open
Conversation
The bare dataset id "wikitext" has been relocated on the Hugging Face Hub. Newer huggingface_hub versions enforce the namespace/name form and reject the bare id, so the @pytest.mark.network test `test_tutorial_train_from_iterators::TestTrainFromIterators::test_datasets` fails on every PR with: HfUriError: Invalid HF URI 'hf://datasets/wikitext@/.huggingface.yaml'. Repository id must be 'namespace/name'. Update both `datasets.load_dataset(...)` call sites in this test to use the canonical relocated id `Salesforce/wikitext`. The config name `wikitext-103-raw-v1` and split arguments are unchanged.
The napi-rs runtime now reports "Failed to get Array length" when an expected `Array` argument is not an array, where it previously reported "Given napi value is not an array". The `bindings/node/lib/bindings/post-processors.test.ts` test asserted the older string, so it fails on every PR. Update the expected error string to match the current napi-rs behaviour. The test still verifies that `bertProcessing(['sep', 1])` (missing the second argument) throws; only the message text changes.
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing CI failures on main, neither related to any code change in tokenizers/ or bindings/{python,node}/src/:
tests/python: use canonical Salesforce/wikitext dataset id — huggingface_hub enforces namespace/name for HF URIs; the bare id "wikitext" (which was relocated on the Hub) now produces HfUriError: Invalid HF URI 'hf://datasets/wikitext@/.huggingface.yaml'. Updates both datasets.load_dataset(...) call sites in test_tutorial_train_from_iterators.py.
tests/node: update bertProcessing error message to match napi-rs — napi-rs now reports "Failed to get Array length" for invalid array args (was "Given napi value is not an array"). Updates the assertion in post-processors.test.ts.
Each is a one-line / two-line change in tests only; no production code touched.