Repository navigation
Raise text under 12 px; call a conversation a conversation in every language - #76
Merged
Merged
Conversation
Font sizes from 7 to 11 px (159 declarations) now use one 12 px variable; on 15 screens at 1440 and 390 px no text is under 12 px, nothing new is clipped and nothing scrolls sideways. A rule test keeps sizes at 12 px or more. The same unit was called session, conversation and task on screen; every language now says conversation, and a running research run is called research. Stored values and identifiers are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups from the post-beta audit.
Text size
--font-small(12 px).typeScaleRules.test.tskeeps new font-size declarations at 12 px or more.One word for a conversation
The screen called the same unit a session, a conversation or a task. Every language now uses one word:
A research run in progress is consistently called research. Translation keys, stored values and thread ids are unchanged. Three unused keys are removed. Three test assertions in
LiveProjectWorkspaceRestart.test.tsxchecked for sentences that do not exist, so they could never fail. They now check the real sentences.Validation