Repository navigation
Run tool installs without package scripts; show why research stopped and earlier-round usage - #81
Merged
Merged
Conversation
…and earlier usage The Codex and Claude Code installs now pass --ignore-scripts. Claude Code's own install script only copies the platform binary over a placeholder, so THOTH does that copy itself, and only when the integrity npm recorded for the wrapper and platform packages matches the values pinned in tool_pins.py. A research request the person stopped now records that fact, and the result card says "You stopped it yourself" instead of "reason not available", on the latest round and on earlier rounds. Cancellations for other reasons and older records are unchanged. Earlier rounds now show the token usage recorded for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three follow-ups to v0.2.0-beta.4.
Tool installs run no package scripts
--ignore-scripts, so no install script of those packages or their dependencies runs.claude.exeover a 500-byte placeholder. THOTH now does that copy itself, and only when the integrity npm recorded for both the wrapper and the platform package matches the values pinned inadapters/models/tool_pins.py. Otherwise the install fails and nothing is copied. The copy is written beside the target and swapped in.codex-cli 0.157.1and2.1.284 (Claude Code). Re-running over an existing install leaves the binary unchanged.Why research stopped
thread/readandoperation/result/readreportUSER_STOPPEDfor that operation, and the result card says "You stopped it yourself" in five languages, on the latest round and on earlier rounds.operation/result/readgets the reason through an injected port, so the general handler does not import research code.Usage on earlier rounds
thread/readcost: about 500 bytes per round. At 10 rounds the median read went from 203 ms to 243 ms; whether that is noise was not separated.Validation