Repository navigation
Validate unknown keywords - #155
Merged
Merged
Conversation
The server runs in its own Node process, so it doesn't need to match the extension's CommonJS build. The banner provides require, __filename and __dirname for bundled CommonJS dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Unknown keywords aren't checked against a meta-schema, so the values of VS Code's keywords, and of deprecated in dialects before 2019-09, could be any JSON value and were used as-is. Accessors now check them against the keyword's meta-schema and ignore invalid values. Only the accessors are affected, not the annotations themselves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unknown keywords produce annotations but aren't checked against a meta-schema, so their values could be anything. This adds infrastructure that allows us to validate unknown keywords against a schema so random values don't break the server.
I also changed the build from CommonJS to ESM because this required top level await and I'd rather it be in ESM anyway.