Repository navigation
fix: validate action broker result timeout - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Slice 23: ActionBroker Timeout Validation.
Closes the deferred hardening gap where
ActionBrokercould be constructed directly with invalid result timeout values.Validation
ActionBrokernow requiresresult_timeoutto be:Rejected immediately:
Valid finite-positive values remain unchanged.
No coercion, clamping, fallback, upper bound, dependency, or new setting was added.
Behavior preserved
No changes to:
/action/action-consumerExisting timeout behavior remains:
unknownconsumer result timed outProduction impact
Production still constructs
ActionBroker()with the existing default:5.0secondsCurrent production configuration does not expose an action-result timeout override.
Existing stale/authentication timeout validation remains unchanged.
Validation
Passed:
git diff --check origin/mainnpm run checkIndependent review found no remaining High, Medium, or Low findings.
Historical audit remains unchanged.