Repository navigation
fix: prevent Windows Mudlet provisioning recursion - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Windows first-launch crash caused by Mudlet helper provisioning recursively copying its own staging directory.
The published v0.3.1 Windows build installs the bundled Mudlet resource at the same path used for writable Mudlet state:
%LOCALAPPDATA%\Imp\mudlet%LOCALAPPDATA%\Imp\mudletOn startup, provisioning creates
.staging-*beneath that directory and recursively copies the source into it. The copy then encounters its own staging directory repeatedly untilimp-desktop.exeterminates withSTATUS_STACK_OVERFLOW (0xC00000FD).Fix
mudlet/tomudlet-bundle/.<local_data>/Imp/mudlet...components.Regression coverage
Adds tests for:
..aliases;..after a missing component;\\?\canonical source vs ordinary path;RESOURCE_DIRand the Tauri resource mapping.Installed first-launch check
Adds
scripts/test-installed-first-launch.ps1to the Windows Build workflow.The check:
Imp.mpackage, andcurrent.txt;.staging-*directories;0xC00000FD;The published v0.3.1 installer reproduces the stack-overflow failure. A branch-built installer has previously started successfully and provisioned the helper.
Validation
npm run check— PASSgit diff --check— cleanInstalled desktop exited with 0xC00000FDMerge gate
Do not merge unless the PR's Windows Build job passes, including the installed first-launch check on the fresh GitHub-hosted Windows runner.
The fresh-runner execution is the remaining acceptance gate for this remediation.
Scope
No changes to Direct WSS, gateway authentication, relay/feed, actions, SSH, native runtime ownership, PyInstaller, Caddy/TLS, version numbers, semantic-release, or
release.yml.