10.2/11.0 compatible versions of Dynamic Tables and Dynamic Objects by Tara McGrew#163
10.2/11.0 compatible versions of Dynamic Tables and Dynamic Objects by Tara McGrew#163TarynVivino wants to merge 4 commits intoi7:11.0from
Conversation
Dynamic Objects and Dynamic Tables extension updated for compatability with Inform 10.2/11 and converted to directory format. (I6 code should probably be moved into "kits" at some point, but this serves as a working, baseline version.)
…fTheseThingsIsNotLikeTheOthers.txt The question-mark in the filename caused checkouts (and without some finagling of the configuration, cloning of the entire repository) to fail in a Windows development environment. Removed the question-mark in the file name, as well as the Example heading, just for consistency.
Question mark in the filename causes checkout on Windows to fail (and indeed, cloning the repository fails for this reason, unless the git configuration is tweaked to ignore the problem) Removed the question mark (?) from the filename and set the example name to match, just for consistency
…distinct from text, and the resulting need to "fix the cloned ... property" for ALL "text" properties of any newly cloned object.
|
Okay, I hope I am going about this correctly. As far as I can tell I am pulling these to the right branch (11.0), even though it wants me to complete a checklist that is clearly meant for version 9 or 10. Going to tick off the last boxes and see if this goes through. |
|
It looks like this was closed without merging, which I don't think is what you want! Unless I've missed something? |
|
No, it wasn't. it's ages since I worked on a public project using GitHub and got myself turned around a bit. I had made an important change to the documentation since the initial pull request, and there were a couple of other minor issues around cloning and checking out a work repository in a Windows environment (specifically two examples with incompatible filenames on Windows, due to a "?" in the filename). What I ended up doing was closing this (by mistake, to be honest), but then just opening another pull request that includes those additional commits. |
2 participants
Dynamic Objects and Dynamic Tables extension updated for compatability with Inform 10.2/11 and converted to directory format. (I6 code should probably be moved into "kits" at some point, but this serves as a working, baseline version.)
Please ensure that you have followed these steps to make a pull request for 10.1 or 9.3 (6M62):
MAJOR.MINOR.PATCH, ex:2.1.0. This means that the major version number must be incremented when and only when you make a change that is not backwards compatible.MAJOR/DATE, ex:2/220517.Extension Name-v1.i7xExtension Name.i7xVersion 1/220517 of Extension Name by Author Name begins here.