tests: replace open-coded Popen+wait patterns with self.exec_cmd()#23
Draft
tests: replace open-coded Popen+wait patterns with self.exec_cmd()#23
Conversation
Agent-Logs-Url: https://github.com/igaw/nvme-cli/sessions/e04bbed5-abd3-4063-9872-24152bf5cc08 Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Agent-Logs-Url: https://github.com/igaw/nvme-cli/sessions/c94edfc8-a4da-40d2-a47c-892dd4a6e765 Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Agent-Logs-Url: https://github.com/igaw/nvme-cli/sessions/c8ec7223-bccb-4a4c-8830-033ea36fa26c Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Agent-Logs-Url: https://github.com/igaw/nvme-cli/sessions/c8ec7223-bccb-4a4c-8830-033ea36fa26c Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Agent-Logs-Url: https://github.com/igaw/nvme-cli/sessions/c8ec7223-bccb-4a4c-8830-033ea36fa26c Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvme_test.py: addimport logging, module-levellogger, configure fromlog_level,logger.debug(cmd)before every subprocess call, replaceself.debug/print()withlogger.debug()nvme_copy_test.py,nvme_format_test.py,nvme_get_features_test.py: add logger,logger.debug(cmd)before each subprocess callconfig.json: documentlog_leveloptionproc.stdout.read()/ line iteration is usedlogging.basicConfig()when no handlers are already installedlines[0]inget_error_logagainst empty output