Repository navigation
Conversation
…errors Closes #83 Signed-off-by: Ilan Harel <ilanharel@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83
The first manual run of the
openshell-nextworkflow (42636278277) went green while doing nothing: the branch has no copy of the scripts, and| teehid the failures.Changes
defaults: run: shell: bashinopenshell-next.ymlruns every step with-eo pipefail, so the redundantset -o pipefailin the test step is gone. I checked the other workflows for the same| teeproblem: composite actions already setshell: bash,ci.ymlandupstream-compat.ymldon't pipe intotee(upstream-compat.shchecksPIPESTATUS), and the pipes inrelease.ymlsit insideif/||checks that fail correctly.scripts/openshell-next.shandscripts/openshell-tags.shto$RUNNER_TEMP/toolsbefore checking outopenshell-next, then runs them against the checkout withOPENSHELL_ANNOTATE_ROOT=$GITHUB_WORKSPACE. Both scripts now honor that env var;openshell-next.shpasses it on toopenshell-tags.shand calls it by absolute path. A fix to the scripts now applies on the next run.unknown.tailof a missing log no longer aborts the comment under-e.always().docs/DEVELOPING.mddescribes the main-tooling and pipefail behaviour andOPENSHELL_ANNOTATE_ROOT, and CHANGELOG has a new line. The AGENTS.md mapping row and RELEASING are unchanged because nothing they describe changed.gen-actions-docs.sh --checkpasses; the composite actions are untouched.Verified (on nemoclaw, in a temp clone)
openshell-{next,tags}.shandupstream-compat.sh.origin/openshell-next(cea9e1e, no scripts).sync origin/mainmerged cleanly.updatemoved the pin from v0.1.8-pre.3 to the newly tagged v0.1.8-pre.4.-D warnings,cargo test --locked,gen-docs.sh --checkandgen-actions-docs.sh --checkall pass.bash -eo pipefailand a stubbedgh:v0.1.8-pre.3.After this merges, one manual run should merge main into
openshell-next, move it to v0.1.8-pre.4, push, dispatch CI on #82 and post a real comment on #80.