Repository navigation
[Vulcan] Verify changed-entry details in changelog override warnings - #372
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require the released version, original entry and override-label reason on the same warning annotation in both changelog override tests (released edit and whole-file deletion). Add a diagnostic-loss mutant that removes the entry while retaining the released-section text: both old tests accepted it, including the deletion test's existing section assertion.
Validation
Scope
Swept both override-warning assertions. Runtime behavior and released changelog are unchanged; no changelog entry for test-only work. No other php_excel PRs were open before publication. PRs #370 and #371 are merged.
From Vulcan.