Skip to content

transpile: Qualify ::c2rust_bitfields::BitfieldStruct in derives#1728

Open
Rua wants to merge 2 commits intoimmunant:masterfrom
Rua:bitfields-struct-derive-fix
Open

transpile: Qualify ::c2rust_bitfields::BitfieldStruct in derives#1728
Rua wants to merge 2 commits intoimmunant:masterfrom
Rua:bitfields-struct-derive-fix

Conversation

@Rua
Copy link
Copy Markdown
Contributor

@Rua Rua commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could we also add a snapshot test for this? You can base it on #1719, too.

@Rua Rua force-pushed the bitfields-struct-derive-fix branch 2 times, most recently from fd042b8 to f20dc29 Compare April 5, 2026 13:07
@Rua
Copy link
Copy Markdown
Contributor Author

Rua commented Apr 5, 2026

Looks like your additions to the snapshot test suite are not enough to clear up the compile errors in this case. Because the derive macro can't be imported, it's not generating methods and now those are also missing.

@Rua Rua force-pushed the bitfields-struct-derive-fix branch from f20dc29 to b3acbe7 Compare April 5, 2026 13:32
@Rua Rua force-pushed the bitfields-struct-derive-fix branch from b3acbe7 to 5109fd7 Compare April 5, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C2Rust-generated bitfield code fails to compile due to missing use c2rust_bitfields::BitfieldStruct

2 participants