Repository navigation
Conversation
skomorokh
requested review from
JanisSaldabols,
adamdickmeiss and
jakub-id
as code owners
November 13, 2026 22:29
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A regression test is still needed to assert US Letter page dimensions, since the existing PDF tests would not catch a reversion to A4.
1 open issue
What changed in this PR
Changes the broker’s pull-slip PDF renderer to use US Letter paper by default, addressing ILLDEV-580.
Changes:
- Replaces the A4 page-size setting with US Letter.
| File | Description |
|---|---|
broker/pullslip/service/pdf.go |
Sets the default pull-slip page size to US Letter. |
Review effort: Balanced
| } | ||
|
|
||
| doc := document.NewDocument(document.PageSizeA4) | ||
| doc := document.NewDocument(document.PageSizeLetter) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.