Repository navigation
ILLDEV-587 Add archiving scheduled actions to UI - #107
JanisSaldabols wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the archive-action settings changes.
No open issues 🎉
What changed in this PR
Adds archiving to the existing scheduled-action settings UI for borrowing requests, lending requests, and ILL transactions.
Changes:
- Registers all three archive actions with shared retention-duration and anonymization controls.
- Adds positive-duration validation, saved-option displays, and English labels.
- Adds tests for creation, editing, viewing, preset loading, validation, and switching action types.
| File | Description |
|---|---|
ui-rs/translations/ui-rs/en.json |
Adds archive action labels and validation messages. |
ui-rs/src/settings/scheduledActions/ScheduledActions.test.js |
Covers creating, updating, and viewing all three archive actions. |
ui-rs/src/settings/scheduledActions/ScheduledActionForm.test.js |
Covers retention validation, presets, and clearing options when switching actions. |
ui-rs/src/settings/scheduledActions/actions/ArchiveParams.js |
Provides shared archive controls, duration validation, and read-only displays. |
ui-rs/src/settings/scheduledActions/actions/actionRegistry.js |
Registers the three archive action types. |
Review effort: Balanced
|
The duration validation is really overbuilt, do we actually want to support sub-second durations anyhow? Instead maybe factor it out from this https://github.com/indexdata/reshare-ui/blob/main/ui-rs/src/settings/scheduledActions/actions/AgeRequestsParams.js |
Changed |
No description provided.