Repository navigation
Make directory ui inheritance-aware - #108
Merged
Merged
Conversation
kurtnordstrom
marked this pull request as ready for review
November 12, 2026 16:48
kurtnordstrom
requested review from
JanisSaldabols,
adamdickmeiss,
ihardy,
jakub-id and
skomorokh
as code owners
November 12, 2026 16:48
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the inheritance-aware directory settings changes.
No open issues 🎉
What changed in this PR
Makes the directory settings UI aware of inheritance, using OpenAPI policy metadata to control field visibility and editing while distinguishing local values from inherited values.
Changes:
- Applies inheritance rules consistently across settings editors, search, and section navigation.
- Edits local values while displaying resolved values, with explicit choices to inherit or store an empty override.
- Adds policy and editor tests, user-facing messages, styling, and documentation.
| File | Description |
|---|---|
ui-rsdir/translations/ui-rsdir/en.json |
Adds inheritance prompts and local-value error messages. |
ui-rsdir/src/util/settingsIndex.test.js |
Updates search coverage for policy-hidden sections. |
ui-rsdir/src/util/settingsIndex.js |
Filters search sections using effective applicability. |
ui-rsdir/src/util/inheritancePolicy.test.js |
Tests inheritance roots, editability, and field filtering. |
ui-rsdir/src/util/inheritancePolicy.js |
Determines whether fields are editable, read-only, or hidden. |
ui-rsdir/src/util/configFieldDescription.js |
Exports schema metadata traversal for policy reuse. |
ui-rsdir/src/routes/ILLConfigRoute.js |
Uses policy-aware fields and waits for policy loading to settle. |
ui-rsdir/src/routes/HoldingsPolicyRoute.js |
Uses policy-aware fields and waits for policy loading to settle. |
ui-rsdir/src/hooks/useEffectiveSections.js |
Combines profile mappings with inheritance policy. |
ui-rsdir/src/config/configSections.js |
Updates section applicability and handles null copyright selections. |
ui-rsdir/src/components/SettingsConfigEditor.test.js |
Covers local editing, inheritance choices, retries, and read-only fields. |
ui-rsdir/src/components/SettingsConfigEditor.js |
Adds local-value loading, inheritance confirmation, and read-only rendering. |
ui-rsdir/src/components/SettingsConfigEditor.css |
Styles inheritance errors, unset notices, and read-only fields. |
ui-rsdir/src/components/EntrySections.js |
Filters navigation using effective sections. |
ui-rsdir/src/components/EntryPane.js |
Passes effective sections to navigation. |
ui-rsdir/FieldMapping.md |
Documents inheritance policy and local-value editing behavior. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.