[adamdickmeiss]

Preserve authentication recall within the current session while excluding these commands from persistent history. Filter existing entries on load and remove them from disk on normal exit.

Redact passwords and OpenStyle strings in confirmations and settings. Cover abbreviations, nested push_command entries, and history cleanup with regression tests. Document the behavior.

[Copilot]

🟡 Changes recommended

The test can fail on clean builds or use a stale client executable, and early exits from command files can leave persisted credentials uncleared.

2 open issues

• Build the client before running its tests · New
• Load history before sourcing files that may exit · New

What changed in this PR

This PR separates yaz-client’s session history from persistent history to keep authentication commands off disk while preserving in-session recall.

Changes:

• Filter authentication commands, including abbreviations and nested push_command entries, and clean existing history on normal exit.
• Redact passwords and OpenStyle strings in confirmations and settings.
• Add regression tests and document the behavior and its limits.

File	Description
test/​test_client_history.sh	Tests persistent-history filtering and cleanup.
test/​test_client_history.c	Tests command classification, session recall, and redaction.
test/​Makefile.am	Registers and links the new tests.
test/​.gitignore	Ignores the new test executable.
doc/​yaz-client-man.xml	Documents history filtering and credential redaction.
client/​fhistory.h	Adds an optional history-filter predicate.
client/​fhistory.c	Filters history entries and supports empty-file cleanup.
client/​client.c	Classifies authentication commands and redacts displayed credentials.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Startup commands can exit before filtered history is loaded, leaving credentials on disk after a normal exit, and duplicate tests are not registered to run under make check.

1 open issue

• Remove unregistered duplicate history tests · New

2 resolved since last review

• Build the client before running its tests
• Load history before sourcing files that may exit

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Persistent history can still leak plaintext passwords through multiline entries, while startup scripts that exit early bypass cleanup of previously saved credentials.

1 open issue

• Reject multiline entries before writing them to persistent history · New

1 resolved since last review

• Remove unregistered duplicate history tests

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

A startup command file that executes quit exits before history is loaded, leaving previously saved credentials on disk despite a normal exit.

No open issues 🎉

1 resolved since last review

• Reject multiline entries before writing them to persistent history

_{Review effort: Balanced}