Repository navigation
Reformats and use odr_strdup_null to simplify - #35
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for this change.
No open issues 🎉
What changed in this PR
This PR simplifies nullable database-name copying and cleans up formatting across the yazpp toolkit’s Z39.50 server, client association, and sample code.
Changes:
- Replaces conditional
odr_strdupusage withodr_strdup_nullin database-record creation. - Standardizes function spacing, indentation, and line wrapping.
- Removes trailing whitespace from copyright comments.
| File | Description |
|---|---|
src/yaz-z-server.cpp |
Simplifies nullable database-name copying and normalizes formatting. |
src/yaz-z-server-update.cpp |
Adjusts update-service call formatting and indentation. |
src/yaz-z-server-sr.cpp |
Reformats retrieval signatures and function calls. |
src/yaz-z-server-ill.cpp |
Normalizes logging-call spacing and comment whitespace. |
src/yaz-z-query.cpp |
Removes trailing whitespace from the copyright comment only. |
src/yaz-z-databases.cpp |
Normalizes database-helper signatures and call spacing. |
src/yaz-my-server.cpp |
Reformats sample-server declarations, definitions, and calls. |
src/yaz-marc-sample.cpp |
Removes trailing whitespace from the copyright comment only. |
src/yaz-ir-assoc.cpp |
Standardizes association-method formatting and indentation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.