Repository navigation
Fix RecordCache::add crash with null record composition - #37
Merged
Merged
Conversation
Skip cloning when the record composition is null. Add test_cache to cover the public RecordCache API, including null compositions, add, lookup, clear, request copying, and size limits.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were reported for the cache null-composition fix and its regression coverage.
No open issues 🎉
What changed in this PR
Fixes a crash in RecordCache::add when a record composition is null and adds regression coverage for the public cache API.
Changes:
- Skip composition cloning when the pointer is null.
- Add tests for null compositions, add/lookup/clear behavior, request copying, and size limits.
- Register the new test program and ignore its generated executable.
| File | Description |
|---|---|
| src/yaz-z-cache.cpp | Guard composition cloning against null pointers. |
| src/test_cache.cpp | Add public RecordCache API regression tests. |
| src/Makefile.am | Register test_cache as a check program. |
| src/.gitignore | Ignore the generated test_cache executable. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip cloning when the record composition is null. Add test_cache to cover the public RecordCache API, including null compositions, add, lookup, clear, request copying, and size limits.