feat(rpc): implement Parity trace_ namespace (9 methods) by prestwich · Pull Request #121 · init4tech/node-components

prestwich · 2026-03-25T23:20:37Z

Summary

Implements the complete Parity/OpenEthereum trace_ JSON-RPC namespace (9 methods) in signet-rpc for Blockscout and general tooling compatibility. Stacks on top of #120.

trace_block, trace_transaction, trace_get — localized Parity traces
trace_replayBlockTransactions, trace_replayTransaction — replay with trace type selection (trace, vmTrace, stateDiff)
trace_call, trace_callMany — call tracing with state/block overrides and accumulated state
trace_rawTransaction — trace from raw RLP bytes
trace_filter — brute-force block range filter with configurable limit (default 100, env SIGNET_RPC_MAX_TRACE_FILTER_BLOCKS)

Architecture: new trace module mirroring debug; two shared Parity tracer functions in debug/tracer.rs; two shared block replay helpers; all handlers semaphore-gated.

Closes ENG-2088, ENG-1064, ENG-1065

Test plan

cargo t -p signet-rpc — 35 unit + 6 doc-tests pass
cargo clippy -p signet-rpc --all-features --all-targets — clean
cargo clippy --all-features --all-targets — workspace clean
cargo +nightly fmt --check — clean
Route count: 9 trace routes wired (62 total)
Manual smoke test against a running node with Blockscout

🤖 Generated with Claude Code

Fraser999 · 2026-03-30T15:41:22Z

crates/rpc/src/config/rpc_config.rs

+    /// Maximum block range for trace_filter queries.
+    #[from_env(
+        var = "SIGNET_RPC_MAX_TRACE_FILTER_BLOCKS",
+        desc = "Maximum block range for trace_filter queries",


Suggested change

desc = "Maximum block range for trace_filter queries",

desc = "Maximum block range for trace_filter queries [default: 100]",

[Claude Code]

Fixed — added [default: 100] to match the other field descriptions.

Fraser999 · 2026-03-30T15:46:25Z

crates/rpc/src/trace/endpoints.rs

+///
+/// Replays all transactions in a block (stopping at the first
+/// magic-signature tx) and returns localized Parity traces.
+#[allow(clippy::too_many_arguments)]


I think this can be removed?

[Claude Code]

Removed. trace_block_localized has 7 params — under clippy's threshold.

Fraser999 · 2026-03-30T15:47:52Z

crates/rpc/src/trace/endpoints.rs

+    <Db as Database>::Error: DBErrorMarker,
+    <Db as DatabaseRef>::Error: DBErrorMarker,
+{
+    use itertools::Itertools;


Import once at the top of the file rather than multiple times inline?

[Claude Code]

Moved to a single top-level import. Removed all 4 inline use itertools::Itertools; statements.

Fraser999 · 2026-03-30T15:51:05Z

crates/rpc/src/trace/endpoints.rs

+    constants: SignetSystemConstants,
+    spec_id: SpecId,
+    header: &alloy::consensus::Header,
+    _block_hash: B256,


Can we remove this param? If we can, we can also remove the #[allow(clippy::too_many_arguments)].

[Claude Code]

Removed _block_hash and the #[allow(clippy::too_many_arguments)] — params drop from 8 to 7.

Fraser999 · 2026-03-30T16:59:59Z

crates/rpc/src/trace/endpoints.rs

+        }
+
+        let max = ctx.config().max_trace_filter_blocks;
+        let distance = end.saturating_sub(start);


Suggested change

let distance = end.saturating_sub(start);

let distance = end.saturating_sub(start) + 1;

[Claude Code]

Fixed — end.saturating_sub(start) + 1 to correctly count inclusive range.

Fraser999 · 2026-03-30T17:16:23Z

crates/rpc/src/trace/endpoints.rs

+            return Err(TraceError::BlockNotFound(BlockId::latest()));
+        }
+        if start > end {
+            return Err(TraceError::EvmHalt {


Not sure that EvmHalt is the best way to describe this. Maybe we could change BlockRangeExceeded to something like InvalidBlockRange and make the requested field a negative value in this case, or just add a completely new error variant for this case?

[Claude Code]

Added a dedicated InvalidBlockRange { reason: String } variant for this case. Maps to -32602 (invalid params) which fits better than -32000 (server error).

Fraser999 · 2026-03-30T17:19:00Z

crates/rpc/src/trace/endpoints.rs

+        if start > latest || end > latest {
+            return Err(TraceError::BlockNotFound(BlockId::latest()));
+        }


Suggested change

if start > latest || end > latest {

return Err(TraceError::BlockNotFound(BlockId::latest()));

}

if start > latest {

return Err(TraceError::BlockNotFound(BlockId::Number(start.into())));

}

if end > latest {

return Err(TraceError::BlockNotFound(BlockId::Number(end.into())));

}

[Claude Code]

Split into two separate checks, each returning BlockNotFound with the specific out-of-range block number.

12 tasks covering TraceError, param types, config, Parity tracer functions, block replay helpers, 9 trace_ endpoints, and router wiring. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Implements the trace_block and trace_transaction async RPC handlers, calling the existing trace_block_localized helper for block-level and per-transaction Parity trace output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…e_get, and trace_filter Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Creates trace/mod.rs with the router constructor and wires it into the combined router. Fixes HashSet type mismatch (std to alloy) and removes erroneous accept_state() call on already-needs-tx state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The docs/ directory is already in .gitignore — these were force-added. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Evalir · 2026-03-31T12:25:45Z

crates/rpc/src/trace/endpoints.rs

+    <Db as Database>::Error: DBErrorMarker,
+    <Db as DatabaseRef>::Error: std::fmt::Debug + DBErrorMarker,
+{
+    use itertools::Itertools;


seems to be imported multiple times?

[Claude Code]

Fixed — moved to a single top-level import.

- Add [default: 100] to trace_filter config description - Move itertools import to top-level, remove inline imports - Remove unused _block_hash param from trace_block_replay - Remove unnecessary #[allow(clippy::too_many_arguments)] - Fix off-by-one in trace_filter block range distance - Add InvalidBlockRange error variant for fromBlock > toBlock - Return specific block numbers in BlockNotFound errors Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

prestwich requested a review from a team as a code owner March 25, 2026 23:20

prestwich requested a review from Fraser999 March 25, 2026 23:24

prestwich marked this pull request as draft March 26, 2026 11:07

prestwich force-pushed the prestwich/parity-trace-namespace branch from 8221a2c to b3d7ca3 Compare March 26, 2026 14:49

prestwich force-pushed the prestwich/eng-960-rpc-namespace-completeness branch from 9af104c to 4dd2e29 Compare March 26, 2026 15:29

prestwich force-pushed the prestwich/parity-trace-namespace branch from b3d7ca3 to 552d4ff Compare March 26, 2026 15:29

prestwich force-pushed the prestwich/eng-960-rpc-namespace-completeness branch from 4dd2e29 to 03bbd7c Compare March 26, 2026 15:38

prestwich force-pushed the prestwich/parity-trace-namespace branch from 552d4ff to d3034ae Compare March 26, 2026 15:38

prestwich force-pushed the prestwich/eng-960-rpc-namespace-completeness branch from 03bbd7c to c0379af Compare March 26, 2026 21:41

prestwich force-pushed the prestwich/parity-trace-namespace branch from d3034ae to d12d1b2 Compare March 26, 2026 21:41

Fraser999 reviewed Mar 30, 2026

View reviewed changes

prestwich force-pushed the prestwich/eng-960-rpc-namespace-completeness branch from c0379af to f3d693c Compare March 30, 2026 17:35

prestwich force-pushed the prestwich/parity-trace-namespace branch from d12d1b2 to 8eb7f8c Compare March 30, 2026 17:42

prestwich force-pushed the prestwich/eng-960-rpc-namespace-completeness branch from f3d693c to f945ca7 Compare March 31, 2026 11:31

prestwich force-pushed the prestwich/parity-trace-namespace branch from 38ee26f to c9734e7 Compare March 31, 2026 11:32

prestwich requested review from Evalir and Fraser999 March 31, 2026 11:38

prestwich and others added 11 commits March 31, 2026 08:08

docs: add Parity trace namespace implementation plan

f66d66c

12 tasks covering TraceError, param types, config, Parity tracer functions, block replay helpers, 9 trace_ endpoints, and router wiring. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat(rpc): add TraceError for Parity trace namespace

c0df97e

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(rpc): add param types for Parity trace namespace

53ce642

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(rpc): add max_trace_filter_blocks config

1af517f

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(rpc): add Parity tracer functions (localized + replay)

a2ca747

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(rpc): add Parity block replay helpers

c245697

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(rpc): add trace_block and trace_transaction

4f64e12

Implements the trace_block and trace_transaction async RPC handlers, calling the existing trace_block_localized helper for block-level and per-transaction Parity trace output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(rpc): add trace_call, trace_callMany, trace_rawTransaction, trac…

360d2b1

…e_get, and trace_filter Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

style(rpc): apply nightly fmt to TraceError

54931a9

chore: remove accidentally committed planning docs

e596c5c

The docs/ directory is already in .gitignore — these were force-added. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

prestwich force-pushed the prestwich/parity-trace-namespace branch from c9734e7 to e596c5c Compare March 31, 2026 12:09

prestwich changed the base branch from prestwich/eng-960-rpc-namespace-completeness to develop March 31, 2026 12:09

prestwich marked this pull request as ready for review March 31, 2026 12:09

Evalir reviewed Mar 31, 2026

View reviewed changes

Fraser999 approved these changes Mar 31, 2026

View reviewed changes

merge: resolve conflict with develop in lib.rs doc comment

2dd1891

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

prestwich enabled auto-merge (squash) March 31, 2026 19:37

prestwich merged commit 7d0a118 into develop Mar 31, 2026
6 checks passed

	desc = "Maximum block range for trace_filter queries",
	desc = "Maximum block range for trace_filter queries [default: 100]",

	let distance = end.saturating_sub(start);
	let distance = end.saturating_sub(start) + 1;

-        if start > latest || end > latest {
-            return Err(TraceError::BlockNotFound(BlockId::latest()));
-        }
+        if start > latest {
+            return Err(TraceError::BlockNotFound(BlockId::Number(start.into())));
+        }
+        if end > latest {
+            return Err(TraceError::BlockNotFound(BlockId::Number(end.into())));
+        }

Conversation

prestwich commented Mar 25, 2026

Summary

Test plan

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants