Skip to content

refactor: replace eyre with AliasError in oracle traits (ENG-2041)#130

Open
prestwich wants to merge 3 commits intomainfrom
prestwich/eng-2041-alias-error
Open

refactor: replace eyre with AliasError in oracle traits (ENG-2041)#130
prestwich wants to merge 3 commits intomainfrom
prestwich/eng-2041-alias-error

Conversation

@prestwich
Copy link
Copy Markdown
Member

Summary

  • Adds a concrete #[non_exhaustive] AliasError enum (with thiserror) to signet-block-processor, replacing eyre::Result in AliasOracle and AliasOracleFactory trait signatures
  • Updates signet-host-reth and signet-host-rpc implementors to use AliasError::Internal(Box::new(e)) for error mapping
  • Removes eyre dependency from signet-host-reth and signet-host-rpc

Motivation

Per convention, library crates should use thiserror, not eyre. The eyre::Result return types in these traits forced all downstream library implementors to depend on eyre.

Test plan

  • cargo clippy --workspace --all-features --all-targets — clean
  • cargo t -p signet-block-processor — pass
  • cargo t -p signet-host-rpc — pass
  • cargo +nightly fmt — no changes

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

prestwich and others added 3 commits April 2, 2026 16:38
…its (ENG-2041)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ENG-2041)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…NG-2041)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@prestwich prestwich requested a review from a team as a code owner April 2, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant