Repository navigation
Add official Qwen memory editing controls, native reopen and verified evidence - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing corpus-window experiments did not establish a need for distinct learned memory rows. Add source-pinned official MEMIT MultiCounterFact editing experiments on Qwen3-0.6B and Qwen3.5-4B, with original decoder replay, masked-gradient checks, three hash capacities, independently trained controls, and calibration-selected inverted-index BM25.
The completed 1,024-edit grid includes 36 trained models and four base/retrieval evaluations across three seeds. Archived candidate scores do not show a stable large-table gain; BM25 has the highest observed quality. Four separately registered frozen-backbone probes retain the locality/generalization tradeoff. Both actual trained native bundles independently reopen with checked next-token logits byte-exact, but both table and complete bundle bytes expand.
The full 20,877-edit grid remains in progress. A final cache log encountered Transformers set-valued loading information after saving the artifacts; preserve the nonzero exits and add explicit hash/coverage-validated resume instead of recomputing completed work. Model, data, training schedule and scoring protocol remain fixed. This PR does not claim editing-method SOTA, large-table necessity, native serving superiority, or generation-metric coverage. The precision audit discloses the installed FLA solver's internal TF32 path.
Validation: 118 local tests passed, with 124 dependency skips (242 discovered), including corruption/coverage/protocol resume checks; real-weight preflights on both models; CPU/CUDA replay fixtures; dependency-free recomputation of all 40 main/4 exploratory scalar reports and RAG calibration selection; optional NumPy reproduction of all 12 paired bootstrap intervals; complete exported-row and 16 actual question-prefix checks per model, including independent native reopen. Exact commands, source snapshots, hashes, costs and failure logs are archived. CI verifies the completed scalar evidence.