docs: better multiversion support for docs v2#2568
Open
git-nandor wants to merge 1 commit into
Open
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
817d7d2 to
d14ada1
Compare
cf96591 to
e713885
Compare
d14ada1 to
c60e824
Compare
matyasf
requested changes
Jun 1, 2026
Collaborator
matyasf
left a comment
There was a problem hiding this comment.
- The "If you are viewing the v11.7 version, switch to v11.6 to see the examples working correctly." text in the legacy/new theme overrides is not needed anymore since the switch is automatic.
- The message "This page always displays the latest version of the documentation" is not clear what it means. I would rephrase it to "This page is made for the latest version (v${major.minor})) of InstUI). Also the linked page https://instructure.design/pr-preview/pr-2568/v11_7/multi-version-system is way too detailed for our users, can you make a new page under Guides that explains the multi version stuff for users? We just need that components are now versioned, the import paths, and what versions work with which theming engine.
- I would not include the Component version selector for non-component pages where it does nothing
- +1: How about displaying components with the "Light" theme when switching to v11.7, since this is now the recommended theme?
e713885 to
ced0fb5
Compare
c60e824 to
7e3bad3
Compare
7e3bad3 to
a04f8e7
Compare
matyasf
approved these changes
Jun 3, 2026
Collaborator
matyasf
left a comment
There was a problem hiding this comment.
Nice work, I like these changes a lot!
| --- | ||
| title: Component versioning | ||
| category: Guides | ||
| order: 5 |
Collaborator
There was a problem hiding this comment.
I think this is an important document, it should be #2, right after the "Getting started" menu point. but its not that important
…ponent versioning guide page
a04f8e7 to
9618859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-5031
Summary
v11.6option in the Component version Select is labeledv11.6 (legacy theming)Co-Authored-By: 🤖 Claude